Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure project to follow standard Maven Standard Directory Layout #48

Closed
aSemy opened this issue Nov 13, 2022 · 2 comments
Closed

Comments

@aSemy
Copy link

aSemy commented Nov 13, 2022

Currently Knit does not follow the Standard Directory Layout

sourceSets {
main.kotlin.dir = "src"
test.kotlin.dir = "test"
main.resources.dir = "resources"
}

While this reduces the number of directories that the project has, I find it makes it much more difficult to navigate as the new files don't follow the conventions that most projects use, and it's unclear what files are within which subproject.

@qwwdfsad
Copy link
Contributor

@qwwdfsad qwwdfsad closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2022
@aSemy
Copy link
Author

aSemy commented Nov 14, 2022

Oh okay, that's a bit weird and confusing. IntelliJ automatically collapses them so it's not a big difference. But okay.

Anyway, implementing buildSrc convention plugins means there's no need for nested subprojects, which would probably help just as much, and make it clear about what files belong to which project.

I'll see if I can update the PR #51 to something like this?

.
└── kotlinx-knit/
    ├── kotlinx-knit-core/
    │   ├── src/
    │   │   ├── Knit.kt
    │   │   └── ...
    │   ├── test/
    │   │   └── ...
    │   ├── testResources/
    │   │   └── testdata/
    │   │       └── ...
    │   └── build.gradle.kts
    └── kotlinx-knit-gradle/
        ├── src/
        │   └── KnitPlugin.kt
        ├── resources/
        │   └── knit.properties
        ├── test/
        ├── testResources/
        ├── testFixtures/
        ├── testFixturesResources/
        └── build.gradle.kts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants