Skip to content

Add buildPersistentList { }, buildPersistentMap { }, buildPersistentSet { } to match the builders in kotlin stdlib #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yogurtearl opened this issue Dec 13, 2022 · 4 comments · May be fixed by #166
Open

Add buildPersistentList { }, buildPersistentMap { }, buildPersistentSet { } to match the builders in kotlin stdlib #137

yogurtearl opened this issue Dec 13, 2022 · 4 comments · May be fixed by #166

Comments

@yogurtearl
Copy link

yogurtearl commented Dec 13, 2022 •
edited
Loading

Add buildPersistentList { }, buildPersistentMap { }, buildPersistentSet { } to match the collection builders in kotlin stdlib

I would imagine it would look something like this:

fun <E> buildPersistentList(block: PersistentList.Builder<E>.() -> Unit): PersistentList<E> = 
    persistentListOf<E>().builder().apply(block).build()
@Shusek
Copy link

Shusek commented Mar 8, 2023 •
edited
Loading

I think it's a good idea but it should be inlined because otherwise it doesn't work at @Composable functions.

@Goooler Goooler linked a pull request Dec 29, 2023 that will close this issue
Open
@Goooler
Copy link
Contributor

Goooler commented Dec 30, 2023

Addressing the fix to #166, can you take a review?

@kyay10
Copy link

kyay10 commented May 24, 2025

It would also be nice to have a size hint as a parameter, just like how stdlib does it. Not sure if that can be implemented efficiently or not though!

@kyay10 kyay10 mentioned this issue May 24, 2025
Closed
@kyay10
Copy link

kyay10 commented May 24, 2025

Good to mention also that this allows for builder inference to be used here, while persistentXOf().mutate requires specifying type arguments explicitly (for now, although I think the compiler team wants to extend type inference to work for this too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add persistent Collection builder functions Goooler/kotlinx.collections.immutable
4 participants
@yogurtearl @Shusek @Goooler @kyay10