Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kotlinx.coroutines.guava.asDeferred() throws on nullable types #1715

Closed
yorickhenning opened this issue Dec 16, 2019 · 1 comment
Closed

kotlinx.coroutines.guava.asDeferred() throws on nullable types #1715

yorickhenning opened this issue Dec 16, 2019 · 1 comment

Comments

@yorickhenning
Copy link
Contributor

One of the fast-path branches in asDeferred() explicitly checks for a null value and throws a NullPointerException if the promise completed with a null. This is wrong, because T can legitimately be a null value. It also disagrees with the other branches, which can successfully complete with a null.
@yorickhenning
Copy link
Contributor Author

Internal issue from a stale import, this is a dupe of #1510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yorickhenning