Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4-parameter version of combine does not use combineUnsafe #2419

Closed
alexvanyo opened this issue Nov 30, 2020 · 3 comments
Closed

4-parameter version of combine does not use combineUnsafe #2419

alexvanyo opened this issue Nov 30, 2020 · 3 comments
Labels
enhancement

Comments

@alexvanyo
Copy link
Contributor

alexvanyo commented Nov 30, 2020 •
edited
Loading

This is a strange discrepancy I noticed in Zip.kt, after the performance improvements of #2308. It looks like the 4 parameter version of combine wasn't updated to use combineUnsafe, unlike the 3 parameter and 5 parameter versions.
@alexvanyo alexvanyo mentioned this issue Nov 30, 2020
Merged
@qwwdfsad
Copy link
Member

Good catch!

@alexvanyo
Copy link
Contributor Author

I opened #2420 to fix this, ready to review at your convenience!

@alexvanyo
Copy link
Contributor Author

Fixed via #2420

This was referenced Mar 8, 2021
Merged
Closed
Closed
Closed
Merged
Closed
This was referenced Mar 15, 2021
Merged
Closed
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qwwdfsad @alexvanyo