Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SerializersModuleCollector.polymorphicDefault and PolymorphicModuleBuilder.default #2076

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

sandwwraith
Copy link
Member

Replaced with default polymorphicDefaultDeserializer and defaultDeserializer respectively. Remove experimentality from SerializersModuleCollector.polymorphicDefaultSerializer.

This is a follow-up for #1686 — finishing migration path

@sandwwraith sandwwraith requested a review from qwwdfsad October 24, 2022 15:41
…icModuleBuilder.default

Replaced with default polymorphicDefaultDeserializer and defaultDeserializer respectively.
Remove experimentality from SerializersModuleCollector.polymorphicDefaultSerializer.

This is a follow-up for #1686 — finishing migration path
@sandwwraith sandwwraith force-pushed the deprecate-default-in-builder branch from 67a137a to 99ab632 Compare October 27, 2022 12:15
@sandwwraith sandwwraith requested a review from qwwdfsad October 27, 2022 12:15
Copy link
Contributor

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@sandwwraith sandwwraith merged commit 1675987 into dev Oct 27, 2022
@sandwwraith sandwwraith deleted the deprecate-default-in-builder branch October 27, 2022 15:27
fred01 pushed a commit to fred01/kotlinx.serialization that referenced this pull request Nov 24, 2022
…icModuleBuilder.default (Kotlin#2076)

Replaced with default polymorphicDefaultDeserializer and defaultDeserializer respectively.
Remove experimentality from SerializersModuleCollector.polymorphicDefaultSerializer.

This is a follow-up for Kotlin#1686 — finishing migration path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants