Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer colors for border-style: ridge/groove/inset/outset #78

Closed
SimonSapin opened this issue Apr 26, 2013 · 1 comment
Closed

Nicer colors for border-style: ridge/groove/inset/outset #78

SimonSapin opened this issue Apr 26, 2013 · 1 comment
Labels
feature New feature that should be supported

Comments

@SimonSapin
Copy link
Member

These border styles need to generate (at least) two shading colors from only one specified border color. WeasyPrint just add/substracts 50% to each RGB channel, but the results are not great.

Here is on Firefox does it. I’m not sure why it’s also based on the background color.
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsCSSColorUtils.cpp#40

@liZe liZe closed this as completed in 4863773 Dec 14, 2013
@liZe
Copy link
Member

liZe commented Dec 14, 2013

I'm quite happy with this new algorithm based on HSV colors. It works well with black, white, gray, saturated and dark colors, but light colors are not darkened very well (nothing's perfect).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature that should be supported
Projects
None yet
Development

No branches or pull requests

2 participants