Images placed incorrectly when cross reference is used #808

mattieusch · 2019-02-19T15:17:44Z

There seems to be a bug in the (re)placement of images that are moved to the next page because of insufficient space on the bottom. These 'moved' images are not rendered or placed on an incorrect location. This issue only manifests itself when a (forward) cross-reference is being used before the image.

See HTML below to reproduce this on WeasyPrint 44, dev version, checked out on 2019-02-19.

<html>
<head>
    <style>
        a.ref::after {
            content: " (p. "target-counter(attr(href), page) ")";
        }
    </style>
</head>

<body class="nl">
  <p>
    <a class="ref" href="#item-1650">Link</a>
    <br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>lorem<br>
  </p>
  <img alt="" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAZAAAAGQCAIAAAAP3aGbAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH4wITDwMSt6ANKwAAAB1pVFh0Q29tbWVudAAAAAAAQ3JlYXRlZCB3aXRoIEdJTVBkLmUHAAAD5UlEQVR42u3UMQ0AAAjAMCD4twwqOEhaCTuW0x0AH5QEgGEBGBZgWACGBWBYgGEBGBaAYQGGBWBYAIYFGBaAYQEYFmBYAIYFYFiAYQEYFoBhAYYFYFgAhgUYFoBhARgWYFgAhgUYFoBhARgWYFgAhgVgWIBhARgWgGEBhgVgWACGBRgWgGEBGBZgWACGBWBYgGEBGBaAYQGGBWBYAIYFGBaAYQEYFmBYAIYFGBaAYQEYFmBYAIYFYFiAYQEYFoBhAYYFYFgAhgUYFoBhARgWYFgAhgVgWIBhARgWgGEBhgVgWACGBRgWgGEBGBZgWACGBRgWgGEBGBZgWACGBWBYgGEBGBaAYQGGBWBYAIYFGBaAYQEYFmBYAIYFYFiAYQEYFoBhAYYFYFgAhgUYFoBhARgWYFgAhgUYFoBhARgWYFgAhgVgWIBhARgWgGEBhgVgWACGBRgWgGEBGBZgWACGBWBYgGEBGBaAYQGGBWBYAIYFGBaAYQEYFmBYAIYFGBaAYQEYFmBYAIYFYFiAYQEYFoBhAYYFYFgAhgUYFoBhARgWYFgAhgVgWIBhARgWgGEBhgVgWACGBRgWgGEBGBZgWACGBRgWgGEBGBZgWACGBWBYgGEBGBaAYQGGBWBYAIYFGBaAYQEYFmBYAIYFYFiAYQEYFoBhAYYFYFgAhgUYFoBhARgWYFgAhgUYFoBhARgWYFgAhgVgWIBhARgWgGEBhgVgWACGBRgWgGEBGBZgWACGBWBYgGEBGBaAYQGGBWBYAIYFGBaAYQEYFmBYAIYFGBaAYQEYFmBYAIYFYFiAYQEYFoBhAYYFYFgAhgUYFoBhARgWYFgAhgVgWIBhARgWgGEBhgVgWACGBRgWgGEBhiUBYFgAhgUYFoBhARgWYFgAhgVgWIBhARgWgGEBhgVgWACGBRgWgGEBGBZgWACGBWBYgGEBGBaAYQGGBWBYAIYFGBaAYQGGBWBYAIYFGBaAYQEYFmBYAIYFYFiAYQEYFoBhAYYFYFgAhgUYFoBhARgWYFgAhgVgWIBhARgWgGEBhgVgWACGBRgWgGEBhgVgWACGBRgWgGEBGBZgWACGBWBYgGEBGBaAYQGGBWBYAIYFGBaAYQEYFmBYAIYFYFiAYQEYFoBhAYYFYFgAhgUYFoBhAYYFYFgAhgUYFoBhARgWYFgAhgVgWIBhARgWgGEBhgVgWACGBRgWgGEBGBZgWACGBWBYgGEBGBaAYQGGBWBYAIYFGBaAYQGGBWBYAIYFGBaAYQEYFmBYAIYFYFiAYQEYFoBhAYYFYFgAhgUYFoBhARgWYFgAhgVgWIBhARgWgGEBhgVwaQFxqQQn9wVzXwAAAABJRU5ErkJggg==">
  <p id="item-1650">Destination</p>
</body>
</html>

The text was updated successfully, but these errors were encountered:

liZe · 2019-02-19T17:06:21Z

Wow. I really don't know where it comes from, I hope it's not a problem in Cairo…

Tontyna · 2019-02-19T18:01:20Z

Neither do I know the reason but when fighting with re-pagination the last time I had the strange ~~impression~~ fact that calling make_page the second time altered (shrinked) some box-margins.

Besides being irritated an wondering what else might be affected by re-make I ignored it for the sake of the actual bug I wanted to fix. Planned to open an issue but as time goes by...

I suppose this time it's not Cairo,

Tontyna · 2019-02-19T19:08:50Z

... ah yes, and like in @mattieusch's snippet there was a coincidence with <br>s

Edit: 😉

Tontyna · 2019-02-19T22:18:40Z

I know what happens, but dont know where and why. Ok. With only one call to make_all_pages the 2 pages look like this:

The blue arrow points to the place where the red square image would be if it would fit on the first page. But it's too big and it's moved -- together with its red-framed div -- to the next page.

Now let's trigger repagination:

Page 1 is forced by the cross-reffed link to be re-made. Page 2 isn't touched, aka up-to-date. But the red square image isn't inside its containing red-framed div anymore. Instead it's at the position where it would be on page 1 if it would fit on page 1; at least it's still on page 2.

@liZe -- do you know why the image -- special beast InlineReplacedBox -- forgets(?) about being a child (?) of its containing box? Though the boxes of page n°2 were left alone?

Guess what happens when page 2 is forced to be re-made, too?

Right you are: The image is at the place where it belongs.

liZe · 2019-02-20T15:06:02Z

I think that there's a kind of cache for replaced boxes, to avoid having the same image multiple times in memory. But … where is this cache, and is it related to this problem? Good questions.

I think it's the same bug as #387.

Tontyna · 2019-02-21T00:53:22Z

The image ist stored as a weasyprint.images.RasterImage object in the InlineReplacedBox.replacement, but that's not the problem. It's the InlineReplacedBox.position_y which is reset automagically by re-making the first page.

Contemplating what make_page is expected to do -- collect the blocks that fit on the current page and return the box (resume_at) that must be pushed on the next page...

Question: How can we detect that a box doesnt fit on the current page?
Answer: We try to put it on the current page and check whether it fits.

If I construe the creative code in blocks.py correctly, that's what it actually does.

Conclusion: The miracle is not the incorrect position of the image, but the red-framed div staying at the top of page n°2. And when the red square is replaced by a big black "X", why for heaven's sake, isn't the TextBox affected?

Tontyna · 2019-02-21T11:52:28Z

No mystery at all:

WeasyPrint/weasyprint/layout/inlines.py

Line 608 in 1d2da09

new_box = atomic_box(

All paginated boxes but AtomicInlineLevelBox are copies, created via split_text_box, split_inline_box, or similar.

Ok, there is more within atomic_box(), but to-be-or-not-to-be-a-copy, that's the question.

mattieusch · 2019-03-01T13:28:04Z

Would there be a workaround conceivable that can be applied from css or html?
Could it be a solution to always trigger the re-make of the page after the page with the cross-ref to have the image placed correctly?

liZe · 2019-03-01T14:19:32Z

Ok, there is more within atomic_box(), but to-be-or-not-to-be-a-copy, that's the question.

Let's copy the box. The same problems also happens with replaced blocks, so I've added two tests to check this. If one day we want to avoid the copy, we'll break the tests and try to find another solution then.

liZe · 2019-03-01T14:20:00Z

I think it's the same bug as #387.

For the record: it was.

Tontyna · 2019-03-01T14:27:46Z

@liZe Good you did it -- me myself had never thought of block_replaced_box_layout

liZe · 2019-03-01T14:35:17Z

@liZe Good you did it -- me myself had never thought of block_replaced_box_layout

I was lucky. As playing with vertical-align was not fun, I've set display: block for the image in the test … and discovered that the bug that was fixed with inline images was still there with block images.

Version 50 ---------- Released on 2019-09-19. New features: * `#209 <https://github.com/Kozea/WeasyPrint/issues/209>`_: Make ``break-*`` properties work inside tables * `#661 <https://github.com/Kozea/WeasyPrint/issues/661>`_: Make blocks with ``overflow: auto`` grow to include floating children Bug fixes: * `#945 <https://github.com/Kozea/WeasyPrint/issues/945>`_: Don't break pages between a list item and its marker * `#727 <https://github.com/Kozea/WeasyPrint/issues/727>`_: Avoid tables lost between pages * `#831 <https://github.com/Kozea/WeasyPrint/issues/831>`_: Ignore auto margins on flex containers * `#923 <https://github.com/Kozea/WeasyPrint/issues/923>`_: Fix a couple of crashes when splitting a line twice * `#896 <https://github.com/Kozea/WeasyPrint/issues/896>`_: Fix skip stack order when using a reverse flex direction Contributors: - grewn0uille - Guillaume Ayoub Version 49 ---------- Released on 2019-09-11. Performance: * Speed and memory use have been largely improved. New features: * `#700 <https://github.com/Kozea/WeasyPrint/issues/700>`_: Handle ``::marker`` pseudo-selector * `135dc06c <https://github.com/Kozea/WeasyPrint/commit/135dc06c>`_: Handle ``recto`` and ``verso`` parameters for page breaks * `#907 <https://github.com/Kozea/WeasyPrint/pull/907>`_: Provide a clean way to build layout contexts Bug fixes: * `#937 <https://github.com/Kozea/WeasyPrint/issues/937>`_: Fix rendering of tables with empty lines and rowspans * `#897 <https://github.com/Kozea/WeasyPrint/issues/897>`_: Don't crash when small columns are wrapped in absolute blocks * `#913 <https://github.com/Kozea/WeasyPrint/issues/913>`_: Fix a test about gradient colors * `#924 <https://github.com/Kozea/WeasyPrint/pull/924>`_: Fix title for document with attachments * `#917 <https://github.com/Kozea/WeasyPrint/issues/917>`_: Fix tests with Pango 1.44 * `#919 <https://github.com/Kozea/WeasyPrint/issues/919>`_: Fix padding and margin management for column flex boxes * `#901 <https://github.com/Kozea/WeasyPrint/issues/901>`_: Fix width of replaced boxes with no intrinsic width * `#906 <https://github.com/Kozea/WeasyPrint/issues/906>`_: Don't respect table cell width when content doesn't fit * `#927 <https://github.com/Kozea/WeasyPrint/pull/927>`_: Don't use deprecated ``logger.warn`` anymore * `a8662794 <https://github.com/Kozea/WeasyPrint/commit/a8662794>`_: Fix margin collapsing between caption and table wrapper * `87d9e84f <https://github.com/Kozea/WeasyPrint/commit/87d9e84f>`_: Avoid infinite loops when rendering columns * `789b80e6 <https://github.com/Kozea/WeasyPrint/commit/789b80e6>`_: Only use in flow children to set columns height * `615e298a <https://github.com/Kozea/WeasyPrint/commit/615e298a>`_: Don't include floating elements each time we try to render a column * `48d8632e <https://github.com/Kozea/WeasyPrint/commit/48d8632e>`_: Avoid not in flow children to compute column height * `e7c452ce <https://github.com/Kozea/WeasyPrint/commit/e7c452ce>`_: Fix collapsing margins for columns * `fb0887cf <https://github.com/Kozea/WeasyPrint/commit/fb0887cf>`_: Fix crash when using currentColor in gradients * `f66df067 <https://github.com/Kozea/WeasyPrint/commit/f66df067>`_: Don't crash when using ex units in word-spacing in letter-spacing * `c790ff20 <https://github.com/Kozea/WeasyPrint/commit/c790ff20>`_: Don't crash when properties needing base URL use var functions * `d63eac31 <https://github.com/Kozea/WeasyPrint/commit/d63eac31>`_: Don't crash with object-fit: non images with no intrinsic size Documentation: * `#900 <https://github.com/Kozea/WeasyPrint/issues/900>`_: Add documentation about semantic versioning * `#692 <https://github.com/Kozea/WeasyPrint/issues/692>`_: Add a snippet about PDF magnification * `#899 <https://github.com/Kozea/WeasyPrint/pull/899>`_: Add .NET wrapper link * `#893 <https://github.com/Kozea/WeasyPrint/pull/893>`_: Fixed wrong nested list comprehension example * `#902 <https://github.com/Kozea/WeasyPrint/pull/902>`_: Add ``state`` to the ``make_bookmark_tree`` documentation * `#921 <https://github.com/Kozea/WeasyPrint/pull/921>`_: Fix typos in the documentation * `#328 <https://github.com/Kozea/WeasyPrint/issues/328>`_: Add CSS sample for forms Contributors: - grewn0uille - Guillaume Ayoub - Raphael Gaschignard - Stani - Szmen - Thomas Dexter - Tontyna Version 48 ---------- Released on 2019-07-08. Dependencies: * CairoSVG 2.4.0+ is now needed New features: * `#891 <https://github.com/Kozea/WeasyPrint/pull/891>`_: Handle ``text-overflow`` * `#878 <https://github.com/Kozea/WeasyPrint/pull/878>`_: Handle ``column-span`` * `#855 <https://github.com/Kozea/WeasyPrint/pull/855>`_: Handle all the ``text-decoration`` features * `#238 <https://github.com/Kozea/WeasyPrint/issues/238>`_: Don't repeat background images when it's not needed * `#875 <https://github.com/Kozea/WeasyPrint/issues/875>`_: Handle ``object-fit`` and ``object-position`` * `#870 <https://github.com/Kozea/WeasyPrint/issues/870>`_: Handle ``bookmark-state`` Bug fixes: * `#686 <https://github.com/Kozea/WeasyPrint/issues/686>`_: Fix column balance when children are not inline * `#885 <https://github.com/Kozea/WeasyPrint/issues/885>`_: Actually use the content box to resolve flex items percentages * `#867 <https://github.com/Kozea/WeasyPrint/issues/867>`_: Fix rendering of KaTeX output, including (1) set row baseline of tables when no cells are baseline-aligned, (2) set baseline for inline tables, (3) don't align lines larger than their parents, (4) force CairoSVG to respect image size defined by CSS. * `#873 <https://github.com/Kozea/WeasyPrint/issues/873>`_: Set a minimum height for empty list elements with outside marker * `#811 <https://github.com/Kozea/WeasyPrint/issues/811>`_: Don't use translations to align flex items * `#851 <https://github.com/Kozea/WeasyPrint/issues/851>`_, `#860 <https://github.com/Kozea/WeasyPrint/issues/860>`_: Don't cut pages when content overflows a very little bit * `#862 <https://github.com/Kozea/WeasyPrint/issues/862>`_: Don't crash when using UTC dates in metadata Documentation: * `#854 <https://github.com/Kozea/WeasyPrint/issues/854>`_: Add a "Tips & Tricks" section Contributors: - Gabriel Corona - Guillaume Ayoub - Manuel Barkhau - Nathan de Maestri - grewn0uille - theopeek Version 47 ---------- Released on 2019-04-12. New features: * `#843 <https://github.com/Kozea/WeasyPrint/pull/843>`_: Handle CSS variables * `#846 <https://github.com/Kozea/WeasyPrint/pull/846>`_: Handle ``:nth()`` page selector * `#847 <https://github.com/Kozea/WeasyPrint/pull/847>`_: Allow users to use a custom SSL context for HTTP requests Bug fixes: * `#797 <https://github.com/Kozea/WeasyPrint/issues/797>`_: Fix underlined justified text * `#836 <https://github.com/Kozea/WeasyPrint/issues/836>`_: Fix crash when flex items are replaced boxes * `#835 <https://github.com/Kozea/WeasyPrint/issues/835>`_: Fix ``margin-break: auto`` Version 46 ---------- Released on 2019-03-20. New features: * `#771 <https://github.com/Kozea/WeasyPrint/issues/771>`_: Handle ``box-decoration-break`` * `#115 <https://github.com/Kozea/WeasyPrint/issues/115>`_: Handle ``margin-break`` * `#821 <https://github.com/Kozea/WeasyPrint/issues/821>`_: Continuous integration includes tests on Windows Bug fixes: * `#765 <https://github.com/Kozea/WeasyPrint/issues/765>`_, `#754 <https://github.com/Kozea/WeasyPrint/issues/754>`_, `#800 <https://github.com/Kozea/WeasyPrint/issues/800>`_: Fix many crashes related to the flex layout * `#783 <https://github.com/Kozea/WeasyPrint/issues/783>`_: Fix a couple of crashes with strange texts * `#827 <https://github.com/Kozea/WeasyPrint/pull/827>`_: Named strings and counters are case-sensitive * `#823 <https://github.com/Kozea/WeasyPrint/pull/823>`_: Shrink min/max-height/width according to box-sizing * `#728 <https://github.com/Kozea/WeasyPrint/issues/728>`_, `#171 <https://github.com/Kozea/WeasyPrint/issues/171>`_: Don't crash when fixed boxes are nested * `#610 <https://github.com/Kozea/WeasyPrint/issues/610>`_, `#828 <https://github.com/Kozea/WeasyPrint/issues/828>`_: Don't crash when preformatted text lines end with a space * `#808 <https://github.com/Kozea/WeasyPrint/issues/808>`_, `#387 <https://github.com/Kozea/WeasyPrint/issues/387>`_: Fix position of some images * `#813 <https://github.com/Kozea/WeasyPrint/issues/813>`_: Don't crash when long preformatted text lines end with ``\n`` Documentation: * `#815 <https://github.com/Kozea/WeasyPrint/pull/815>`_: Add documentation about custom ``url_fetcher``

liZe added the bug Existing features not working as expected label Feb 19, 2019

liZe closed this as completed in f79110c Mar 1, 2019

liZe added this to the 46 milestone Mar 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Images placed incorrectly when cross reference is used #808

Images placed incorrectly when cross reference is used #808

mattieusch commented Feb 19, 2019 •

edited

Loading

liZe commented Feb 19, 2019

Tontyna commented Feb 19, 2019

Tontyna commented Feb 19, 2019 •

edited

Loading

Tontyna commented Feb 19, 2019 •

edited

Loading

liZe commented Feb 20, 2019

Tontyna commented Feb 21, 2019

Tontyna commented Feb 21, 2019 •

edited

Loading

mattieusch commented Mar 1, 2019

liZe commented Mar 1, 2019

liZe commented Mar 1, 2019

Tontyna commented Mar 1, 2019

liZe commented Mar 1, 2019

Images placed incorrectly when cross reference is used #808

Images placed incorrectly when cross reference is used #808

Comments

mattieusch commented Feb 19, 2019 • edited Loading

liZe commented Feb 19, 2019

Tontyna commented Feb 19, 2019

Tontyna commented Feb 19, 2019 • edited Loading

Tontyna commented Feb 19, 2019 • edited Loading

liZe commented Feb 20, 2019

Tontyna commented Feb 21, 2019

Tontyna commented Feb 21, 2019 • edited Loading

mattieusch commented Mar 1, 2019

liZe commented Mar 1, 2019

liZe commented Mar 1, 2019

Tontyna commented Mar 1, 2019

liZe commented Mar 1, 2019

mattieusch commented Feb 19, 2019 •

edited

Loading

Tontyna commented Feb 19, 2019 •

edited

Loading

Tontyna commented Feb 19, 2019 •

edited

Loading

Tontyna commented Feb 21, 2019 •

edited

Loading