Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CSS grid #13

Closed
audreytoskin opened this issue Apr 16, 2019 · 2 comments
Closed

Add support for CSS grid #13

audreytoskin opened this issue Apr 16, 2019 · 2 comments

Comments

@audreytoskin
Copy link

I have an HTML document I'm trying to convert to PDF using WeasyPrint. The HTML version makes heavy use of CSS grid styles, and when trying to do the conversion, I get a bunch of warnings about the grid styles being ignored, because of "unknown property" errors.

WARNING: Ignored `display: grid` at 84:3, invalid value.
WARNING: Ignored `grid-column-gap: 1em` at 85:3, unknown property.
WARNING: Ignored `grid-template-columns: 1fr 1fr 1.5fr` at 86:3, unknown property.
WARNING: Ignored `grid-column: 1/4` at 92:3, unknown property.
WARNING: Ignored `display: grid` at 156:3, invalid value.
WARNING: Ignored `grid-gap: 0.5em` at 157:3, unknown property.
WARNING: Ignored `grid-template-columns: 1fr 1fr` at 158:3, unknown property.
WARNING: Ignored `grid-column: 1` at 168:3, unknown property.
WARNING: Ignored `grid-row: 2` at 169:3, unknown property.
[...]

I could be wrong, but I guess this is because tinycss2 doesn't support grid styles yet?

@audreytoskin
Copy link
Author

Oh, sorry, I just noticed someone else made the same request in Kozea/WeasyPrint#543 too.

@liZe
Copy link
Member

liZe commented Apr 17, 2019

Oh, sorry, I just noticed someone else made the same request in Kozea/WeasyPrint#543 too.

Yes, everything's already done in tinycss2 and cssselect2, the work is needed in WeasyPrint!

@liZe liZe closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants