Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Data flow #274

Open
2 tasks
KristianWEB opened this issue May 22, 2020 · 0 comments
Open
2 tasks

Components: Data flow #274

KristianWEB opened this issue May 22, 2020 · 0 comments
Labels
question Further information is requested UI Work on the Front-end

Comments

@KristianWEB
Copy link
Owner

KristianWEB commented May 22, 2020

Is your feature request related to a problem? Please describe.
ProfilePage, ProfileHeader, Comment, Post and every component that's associated to the authenticated user is also associated to the guest ( for example another user in the app ).

  • Now the problem is that when you open the profile page of somebody else it first shows your data and then switches to his/her data when it arrives and that's not how I want it to work. So maybe we can have a HOC Route which sends the user to 2 different layouts ( one with the authenticated user, and another for the other user ) which means that we will have 2 versions of components for each feature. I'm not really sure if this is ideal to do, so I will label this issue as a question. Let me know if there are better ways of handling authUser/urlUser ( other users ) in the app.
  • Also it would be perfect if we can combine profileRoute & privateRoute because they both contain duplicated data ( subscriptions ) and they are almost identical.

You can work on this feature by creating and using a branch called feature/fix-routes

@KristianWEB KristianWEB added question Further information is requested UI Work on the Front-end labels May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested UI Work on the Front-end
Projects
None yet
Development

No branches or pull requests

1 participant