Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Ribbon backcolours to match theme panel colour(s) #1565

Closed
Smurf-IV opened this issue Jun 23, 2024 · 8 comments
Closed

[Bug]: Ribbon backcolours to match theme panel colour(s) #1565

Smurf-IV opened this issue Jun 23, 2024 · 8 comments
Labels
area:ribbon All issues to do with the ribbon. area:themes All things to do with themes. bug Something isn't working completed This issue has been completed. regression Something was working in a previous release, but isn't working now. version:85-lts All things to do with V85 LTS. version:90 All things to do with V90.

Comments

@Smurf-IV
Copy link
Member

Using today's alpha and the Ribbon Controls demo (.net core)

Expected:

image

Actual:

image

etc.
@Smurf-IV Smurf-IV added bug Something isn't working area:themes All things to do with themes. area:ribbon All issues to do with the ribbon. regression Something was working in a previous release, but isn't working now. labels Jun 23, 2024
@PWagner1
Copy link
Contributor

This will likely fix #1564

@PWagner1
Copy link
Contributor

Appears to be controlled by

Color.FromArgb(190, 190, 190), // RibbonGroupsArea1
            Color.FromArgb(210, 210, 210), // RibbonGroupsArea2
            Color.FromArgb(213, 219, 231), // RibbonGroupsArea3
            Color.FromArgb(249, 249, 249), // RibbonGroupsArea4
            Color.FromArgb(243, 245, 249), // RibbonGroupsArea5

@PWagner1
Copy link
Contributor

Ok, so the back colour is controlled by these values

image

@giduac giduac self-assigned this Aug 29, 2024
@giduac giduac added under investigation This bug/issue is currently under investigation. version:85-lts All things to do with V85 LTS. version:90 All things to do with V90. awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. and removed under investigation This bug/issue is currently under investigation. labels Aug 29, 2024
@giduac
Copy link

giduac commented Oct 12, 2024

@Wagnerp & @Smurf-IV,

The Visual Studio and 365 varieties have the same background color as the Panel.
But for my taste it also looks good when the Ribbon contrasts against the Panel.
I think that should be the choice of the user and be left as it is...

@giduac
Copy link

giduac commented Oct 15, 2024

Reporter is not responding.
Ticket will be closed, if needed it can be reopened.

@giduac giduac closed this as completed Oct 15, 2024
@giduac giduac removed their assignment Oct 15, 2024
@giduac giduac added completed This issue has been completed. and removed awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. labels Oct 15, 2024
@Smurf-IV
Copy link
Member Author

Reporter is not responding. Ticket will be closed, if needed it can be reopened.

Hey, I was on holiday!
3 days - hmph.

@giduac
Copy link

giduac commented Oct 15, 2024

@I.ve asked a couple of weeks ago as well ...

@giduac
Copy link

giduac commented Oct 15, 2024

https://discord.com/channels/620577714889424916/784104286074175539/1278935160254894174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:ribbon All issues to do with the ribbon. area:themes All things to do with themes. bug Something isn't working completed This issue has been completed. regression Something was working in a previous release, but isn't working now. version:85-lts All things to do with V85 LTS. version:90 All things to do with V90.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PWagner1 @Smurf-IV @giduac