Reject unsupported last_over_time during verification (elastic#136517)

This change updates the validation to reject time-series aggregations 
that cannot be executed. Specifically, if FN(field) is rewritten to
FN(last_over_time(field)), and we don't support last_over_time(field),
we should throw an error during planning rather than at runtime.

Closes elastic#136270

Author: dnhatn

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/GenerativeRestTest.java

@@ -76,9 +76,7 @@ public abstract class GenerativeRestTest extends ESRestTestCase implements Query
         "time-series.*the first aggregation.*is not allowed",
         "count_star .* can't be used with TS command",
         "time_series aggregate.* can only be used with the TS command",
-        "Invalid call to dataType on an unresolved object \\?LASTOVERTIME", // https://github.com/elastic/elasticsearch/issues/134791
-        // https://github.com/elastic/elasticsearch/issues/134793
-        "class org.elasticsearch.compute.data..*Block cannot be cast to class org.elasticsearch.compute.data..*Block"
+        "implicit time-series aggregation function .* doesn't support type .*"
     );
 
     public static final Set<Pattern> ALLOWED_ERROR_PATTERNS = ALLOWED_ERRORS.stream()

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/TimeSeriesAggregate.java

@@ -14,11 +14,14 @@
 import org.elasticsearch.xpack.esql.core.expression.Alias;
 import org.elasticsearch.xpack.esql.core.expression.Expression;
 import org.elasticsearch.xpack.esql.core.expression.FieldAttribute;
+import org.elasticsearch.xpack.esql.core.expression.Literal;
 import org.elasticsearch.xpack.esql.core.expression.NamedExpression;
 import org.elasticsearch.xpack.esql.core.tree.NodeInfo;
 import org.elasticsearch.xpack.esql.core.tree.Source;
+import org.elasticsearch.xpack.esql.core.type.DataType;
 import org.elasticsearch.xpack.esql.expression.function.aggregate.AggregateFunction;
 import org.elasticsearch.xpack.esql.expression.function.aggregate.Count;
+import org.elasticsearch.xpack.esql.expression.function.aggregate.LastOverTime;
 import org.elasticsearch.xpack.esql.expression.function.aggregate.TimeSeriesAggregateFunction;
 import org.elasticsearch.xpack.esql.expression.function.grouping.Bucket;
 import org.elasticsearch.xpack.esql.plan.logical.join.LookupJoin;
@@ -202,21 +205,23 @@ protected void checkTimeSeriesAggregates(Failures failures) {
                     failures.add(
                         fail(count, "count_star [{}] can't be used with TS command; use count on a field instead", outer.sourceText())
                     );
-                }
-                outer.forEachDown(FieldAttribute.class, fa -> {
-                    if (fa.isDimension()) {
+                    // reject COUNT(keyword), but allow COUNT(numeric)
+                } else if (outer instanceof TimeSeriesAggregateFunction == false && outer.field() instanceof AggregateFunction == false) {
+                    Expression field = outer.field();
+                    var lastOverTime = new LastOverTime(source(), field, new Literal(source(), null, DataType.DATETIME));
+                    if (lastOverTime.typeResolved() != Expression.TypeResolution.TYPE_RESOLVED) {
                         failures.add(
                             fail(
                                 this,
-                                "cannot use dimension field [{}] in a time-series aggregation function [{}]. "
-                                    + "Dimension fields can only be used for grouping in a BY clause. To aggregate "
-                                    + "dimension fields, use the FROM command instead of the TS command.",
-                                fa.sourceText(),
-                                outer.sourceText()
+                                "implicit time-series aggregation function [{}] generated from [{}] doesn't support type [{}], "
+                                    + "only numeric types are supported; use the FROM command instead of the TS command",
+                                outer.sourceText().replace(field.sourceText(), "last_over_time(" + field.sourceText() + ")"),
+                                outer.sourceText(),
+                                field.dataType().typeName()
                             )
                         );
                     }
-                });
+                }
                 if (outer instanceof TimeSeriesAggregateFunction ts) {
                     outer.field()
                         .forEachDown(

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java

@@ -2696,17 +2696,17 @@ public void testNoDimensionsInAggsOnlyInByClause() {
         assertThat(
             error("TS test | STATS count(host) BY bucket(@timestamp, 1 minute)", tsdb),
             equalTo(
-                "1:11: cannot use dimension field [host] in a time-series aggregation function [count(host)]. "
-                    + "Dimension fields can only be used for grouping in a BY clause. "
-                    + "To aggregate dimension fields, use the FROM command instead of the TS command."
+                "1:11: implicit time-series aggregation function [count(last_over_time(host))] "
+                    + "generated from [count(host)] doesn't support type [keyword], only numeric types are supported; "
+                    + "use the FROM command instead of the TS command"
             )
         );
         assertThat(
-            error("TS test | STATS count(count_over_time(host)) BY bucket(@timestamp, 1 minute)", tsdb),
+            error("TS test | STATS max(name) BY bucket(@timestamp, 1 minute)", tsdb),
             equalTo(
-                "1:11: cannot use dimension field [host] in a time-series aggregation function [count(count_over_time(host))]. "
-                    + "Dimension fields can only be used for grouping in a BY clause. "
-                    + "To aggregate dimension fields, use the FROM command instead of the TS command."
+                "1:11: implicit time-series aggregation function [max(last_over_time(name))] "
+                    + "generated from [max(name)] doesn't support type [keyword], only numeric types are supported; "
+                    + "use the FROM command instead of the TS command"
             )
         );
     }