-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in color scale of 3D representations in the Colab implementation #12
Comments
Hi Matias, Thank you for bringing this bug to our attention! I agree that it would be good to have the matrix and 3D representation color scales match. I have updated the Colab code as follows:
However, it appears that a recent Colab update may have broken NGLView widgets, which generate the 3D representation. I am unable to get the 3D representation to load now, and have found some issues that report the same behavior. I have added a note explaining as much in the Colab. Thanks, |
Hi!
The Colab implementation of ThermoMPNN is very nice, but I found an issue in the 3D representation (Step 6C).
The color scale for "RAW", "BEST" and "ALA" methods is set from red to blue, but should be the other way around to follow the color code in the matrix image.
if cs = "RdBu", then "colorDomain" should be set [max_sens, min_sens], to render a scale from blue (stable) to red...
Additionally, the range of the color scale in the 3D representation differs from the matrix image. In particular defining:
min_sens, max_sens = min(sensitivity), max(sensitivity)
May create an asymmetric scale around zero, then a white color may stand for a different value in a linear gradient... A better choice may be using fixed values (e.g. min_sens=-3; max_sens=3) or setting the absolute maximum value to both variables.
Best regards
The text was updated successfully, but these errors were encountered: