Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support resize records when rolloutRun.spec changes #27

Closed
40lsgy1 opened this issue Jan 9, 2024 · 2 comments
Closed

support resize records when rolloutRun.spec changes #27

40lsgy1 opened this issue Jan 9, 2024 · 2 comments

Comments

@40lsgy1
Copy link
Collaborator

40lsgy1 commented Jan 9, 2024 •
edited
Loading

We need to resize status.RolloutBatchStatus.Records firstly because status.Batches may be changed

Originally posted by @zoumo in #21 (comment)
@40lsgy1 40lsgy1 changed the title We need to resize status.RolloutBatchStatus.Records firstly because status.Batches may be changed support resize records when rolloutRun.spec changes Jan 9, 2024
@40lsgy1
Copy link
Collaborator Author

40lsgy1 commented Jan 9, 2024 •
edited
Loading

Feature Request

Describe the feature you'd like:

  • only the initial batches can be changed/appended/removed. others will be blocked by rolloutRun webhook
  • rolloutRun.status will add attribute such as ' observedSpecHash'。when rolloutRun.phase == Rolling，executor will check observedSpecHash, if diff exist, executor will resize records

Describe alternatives you've considered:

none yet

Teachability, Documentation, Adoption, Migration Strategy:

@40lsgy1 40lsgy1 mentioned this issue Jan 9, 2024
Merged
16 tasks
@zoumo
Copy link
Collaborator

zoumo commented Jan 30, 2024

fixed in #37

@zoumo zoumo closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zoumo @40lsgy1