Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to sort by frequency of words in a language #23

Open
PANICBUTT0N opened this issue Nov 20, 2024 · 3 comments
Open

Add option to sort by frequency of words in a language #23

PANICBUTT0N opened this issue Nov 20, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@PANICBUTT0N
Copy link

Sorting by frequency does not appear to do anything, and outputs the exact same result that sorting by score does.

Sorted by frequency:
frequency

Sorted by score:
score

@Kuuuube
Copy link
Owner

Kuuuube commented Nov 20, 2024

From my understanding of RTK, this is expected. Frequency in this case does not mean frequency of the kanji appearing in the language. It means the number of cards containing the kanji.

For example: If you have 気 in 5 cards and 二 in 3 cards then it will order it 気 二. I think RTK only has one character per card so it would never have any frequency to sort by.

@PANICBUTT0N
Copy link
Author

From my understanding of RTK, this is expected. Frequency in this case does not mean frequency of the kanji appearing in the language. It means the number of cards containing the kanji.

For example: If you have 気 in 5 cards and 二 in 3 cards then it will order it 気 二. I think RTK only has one character per card so it would never have any frequency to sort by.

Ah, I see, I assumed it was the latter. Have you considered implementing language word frequency? An implementation of rspeer's wordfreq seems fairly doable.

@Kuuuube
Copy link
Owner

Kuuuube commented Nov 20, 2024

It certainly is possible but I'm not sure it's worth adding sort by options like this. The JPDB kanji frequency list is present in the group by section.

@Kuuuube Kuuuube changed the title Sorting by frequency non-functional Add option to sort by frequency of words in a language Dec 3, 2024
@Kuuuube Kuuuube added the enhancement New feature or request label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants