Go interpreter syntax check (#37)

Go interpreter syntax check

Author: Ilya Kaznacheev

Go/README.md

@@ -16,7 +16,7 @@ and use Process() method
 package main
 
 import (
-	petooh "github.com/Ky6uk/PETOOH/Go/petooh"
+	"github.com/Ky6uk/PETOOH/Go/petooh"
 )
 ...
 err := petooh.Process(r, w)

Go/petooh/petooh.go

@@ -18,6 +18,25 @@ const (
 	validRunes = "adehkKoOru"
 )
 
+var koCommands = []string{
+	koIncPtr,
+	koDecPtr,
+	koInc,
+	koDec,
+	koOut,
+	koJmp,
+	koRet,
+}
+
+func isCMDSyntaxOK(cmd string) bool {
+	for _, koCMD := range koCommands {
+		if strings.HasPrefix(koCMD, cmd) {
+			return true
+		}
+	}
+	return false
+}
+
 // Process function parses and processes source code commands
 //
 // r should contains source code
@@ -125,6 +144,10 @@ func Process(r io.Reader, w io.Writer) error {
 				w.Write([]byte(string(cells[pointer])))
 			}
 			buffer = ""
+		default:
+			if !isCMDSyntaxOK(buffer) {
+				return errors.New("wrong command: " + buffer)
+			}
 		}
 
 		if exit {

Go/petooh/petooh_test.go

@@ -3,18 +3,29 @@ package petooh
 import (
 	"bytes"
 	"errors"
+	"io"
 	"strings"
 	"testing"
 )
 
-const source = `KoKoKoKoKoKoKoKoKoKo Kud-Kudah
+const (
+	valDefault = `KoKoKoKoKoKoKoKoKoKo Kud-Kudah
 	KoKoKoKoKoKoKoKo kudah kO kud-Kudah Kukarek kudah
 	KoKoKo Kud-Kudah
 	kOkOkOkO kudah kO kud-Kudah Ko Kukarek kudah
 	KoKoKoKo Kud-Kudah KoKoKoKo kudah kO kud-Kudah kO Kukarek
 	kOkOkOkOkO Kukarek Kukarek kOkOkOkOkOkOkO
 	Kukarek`
-const res = "PETOOH"
+	wrongSyntax   = `Kudak`
+	wrongPointer  = `kudah`
+	wrongPointerL = `KoKudkudahkud`
+	wrongLevel    = `kudkud`
+	valLvl        = `KudahKokudahKoKudKudah
+	KoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKo
+	KoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKo
+	KoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKoKo
+	KoKoKoKoKukarekkudahkOkud`
+)
 
 type errorReader struct {
 }
@@ -23,32 +34,41 @@ func (er errorReader) Read(p []byte) (n int, err error) {
 	return 0, errors.New("test")
 }
 
-func TestProcess(t *testing.T) {
-
-	r := strings.NewReader(source)
-
+func processTestData(r io.Reader) (string, error) {
 	w := bytes.NewBuffer([]byte{})
-
 	err := Process(r, w)
+	return w.String(), err
+}
 
-	if w.String() != res {
-		t.Errorf("method returns false result %s, but %s expected", w.String(), res)
-	}
-
-	if err != nil {
-		t.Errorf("failed on source code processing: %s", err)
+func TestProcess(t *testing.T) {
+	for _, td := range []struct {
+		r   io.Reader
+		exp string
+	}{
+		{strings.NewReader(valDefault), "PETOOH"}, //default example
+		{strings.NewReader(valLvl), "A"},          //simple example with A
+	} {
+		res, err := processTestData(td.r)
+		if res != td.exp {
+			t.Errorf("method returns false result %s, but %s expected", res, td.exp)
+		}
+		if err != nil {
+			t.Errorf("failed on valDefault code processing: %s", err)
+		}
 	}
-
 }
 
 func TestProcessEmpty(t *testing.T) {
-	r := errorReader{}
-
-	w := bytes.NewBuffer([]byte{})
-
-	err := Process(r, w)
-
-	if err == nil {
-		t.Error("should be error but no error was returned")
+	for _, r := range []io.Reader{
+		errorReader{},
+		strings.NewReader(wrongSyntax),   //wrong sintax example
+		strings.NewReader(wrongPointer),  //negative pointer
+		strings.NewReader(wrongPointerL), //negative pointer on second level
+		strings.NewReader(wrongLevel),    //negative level
+	} {
+		_, err := processTestData(r)
+		if err == nil {
+			t.Error("should be error but no error was returned")
+		}
 	}
 }