Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialState className #45

Closed
PHaroZ opened this issue Jan 11, 2016 · 3 comments · Fixed by #58
Closed

initialState className #45

PHaroZ opened this issue Jan 11, 2016 · 3 comments · Fixed by #58

Comments

@PHaroZ
Copy link

PHaroZ commented Jan 11, 2016

Hi,

First, thanks for your job, it's pretty cool :)

After reading src code I see that when state change to "unfixed" className is set to "headroom--unfixed", which is pretty cool for custom styling.
However in getInitialState state is to "unfixed" but className is to "headroom--pinned", this seems to be an issue and makes useless the "headroom--unfixed" class.

@tzvigqb
Copy link
Contributor

tzvigqb commented Apr 13, 2016

I agree with @PHaroZ on this. In my case, since we start out with "headroom--pinned", I can't do custom styling for the initial state. It has to be the same as when unpinned, which does not work for me.

@KyleAMathews
Copy link
Owner

I'd accept a PR for this and #43 (which seems a very similar problem).

@KyleAMathews
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants