Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send speaking stop updates #21

Open
MinnDevelopment opened this issue Sep 4, 2022 · 1 comment
Open

Do not send speaking stop updates #21

MinnDevelopment opened this issue Sep 4, 2022 · 1 comment
Milestone

Comments

@MinnDevelopment
Copy link

For a few years now, discord doesn't need you to send an update when you stop speaking. This is now handled entirely client-side. The client automatically detects when the stream of datagrams stops, and sets the speaking flag off locally.

This solves the problem of tracks ending early because of buffering, which is caused by early speaking stop updates. Instead, only send these updates when playback starts or the mask changes (priority/soundshare/voice), but never when the playback stops.

@alula
Copy link
Member

alula commented Mar 12, 2024

This was the default behavior in early versions of Koe and people complained about it. I think I should reintroduce it as an option.

@alula alula added this to the 2.1 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants