New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"set accuracy =1 on classes with no samples" may not be correct #31

Open

raffaello-camoriano opened this issue Nov 24, 2017 · 0 comments

Member

raffaello-camoriano commented Nov 24, 2017 •

edited

Loading

I might be wrong, but this line doesn't seem to be setting the right elements of perClass to 1.

GURLS/gurls++/include/gurls++/macroavg.h

Line 312 in d9d0d31

set(perClass+perClass_length, (T)1.0, totClasses-perClass_length);

I suggest to do:

        if (*den == 0.0)
        {
            // Set accuracy =1 on classes with no sampless
            perClass[i] = (T)1.0;
        }
        else
        {
            perClass[i] = ((T)(*num))/((*den) + std::numeric_limits<T>::epsilon());
        }

raffaello-camoriano self-assigned this

raffaello-camoriano removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment