Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Can't cycle stack windows if stack is monocled #1074

Open
alex-ds13 opened this issue Oct 21, 2024 · 1 comment · May be fixed by #1076
Open

[BUG]: Can't cycle stack windows if stack is monocled #1074

alex-ds13 opened this issue Oct 21, 2024 · 1 comment · May be fixed by #1076
Labels
bug Something isn't working

Comments

@alex-ds13
Copy link
Contributor

alex-ds13 commented Oct 21, 2024

Summary

If we monocle a stack container we won't be able to use the cycle-stack or focus-stack-window commands since those try to operate on the self.focused_container of the window manager which when monocled is incorrect, since it only looks on the workspace containers ignoring the monocle container.

Version Information

0.1.29+

Komorebi Configuration

(not needed)

Hotkey Configuration

(not needed)

Output of komorebic check

(not needed)

@alex-ds13 alex-ds13 added the bug Something isn't working label Oct 21, 2024
@alex-ds13
Copy link
Contributor Author

@LGUG2Z Feel free to assign this one to me as well.

I will fix this one by adding a check for monocle containers first.

However I feel that a bunch of this issues would be non-existent if instead of removing the containers from the workspace containers ring to move that container to the monocle, we kept the containers always on the ring and simply set the container id to the monocle. Same thing for floating_windows they could still have their container on the ring and then the floating_windows would be a vec of ids. This way the focused container could always be get easily from the ring. And even floating windows could be focused meaning that when changing workspaces if that floating window was focused we would be able to set it to focused again. But this is a discussion for another time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant