Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron applications not respecting Windows border conventions are not correctly placed #32

Closed
LGUG2Z opened this issue Sep 13, 2021 · 0 comments
Assignees
Labels
chromium/electron bug A bug in Chromium is causing issues with Electron apps enhancement New feature or request

Comments

@LGUG2Z
Copy link
Owner

LGUG2Z commented Sep 13, 2021

Some Electron applications such as Spotify and Discord do not respect the Windows invisible border conventions, and instead find a way to push the client area to draw over the invisible borders, essentially removing the invisible borders by drawing over them.

This means that by default, komorebi is placing them in an incorrect position which is off by the default invisible border offset:

let border = Rect {
    left: 12,
    top: 0,
    right: 24,
    bottom: 12,
};

A komorebic command should be added to identify these applications so that the invisible border removal logic when positioning windows can be skipped conditionally based on what the user has configured.

@LGUG2Z LGUG2Z added the enhancement New feature or request label Sep 13, 2021
@LGUG2Z LGUG2Z self-assigned this Sep 13, 2021
@LGUG2Z LGUG2Z added the chromium/electron bug A bug in Chromium is causing issues with Electron apps label Sep 13, 2021
@LGUG2Z LGUG2Z closed this as completed in ff53533 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chromium/electron bug A bug in Chromium is causing issues with Electron apps enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant