feat(wm): ultrawide layout resizing #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Workspace::enforce_resize_constraints to enforce constraints differently for different layouts Add enforce_no_resize method for all but bsp layout resize_dimensions
Add Workspace::enforce_resize_for_ultrawide method to apply resize constraints for ultrawide vertical stack layout.
Add function calculate_ultrawide_adjustment to calculate adjustments for individual containers in ultrawide vertical stack layout Refactor ultrawide layout generation in separate function and use calculated adjustments
Add some helper function and descriptive variable names in calculate_ultrawide_adjustment Apply clippy lints
|
I have checked this out and I'll be running it for a few days; so far so amazing! I'll try to start looking at the code itself closer to the end of the week, but I hope that this can be a part of the next release. 🙏 |
LGUG2Z
changed the title
|
@NotLebedev Really enjoyed testing this over the last two weeks, from what I can tell this is rock solid! Thank you so much for this very important contribution! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only BSP layout and primary container of custom layouts can be resized. BSP layout is not very good for ultrawide screens and resizing only primary container is limiting. This PR adds resizing for
ultrawide-vertical-stacklayout and refactors some code related to resize calculation.Workspace::enforce_resize_constraintscan now enforce different constraints for different layouts and for those layouts that can not be resizedresize_dimensionsis explicitly set to 0 (previously everything was constrained as for BSP)ultrawide-vertical-stacklayout, which can be resized differently then BSPultrawide-vertical-stacknow applyresize_dimensionsvia new functioncalculate_ultrawide_adjustment. Base layout is kept the same, resizing changes are applied on top