Skip to content

Commit 3b54b9d

Browse files
authoredJun 30, 2020
Merge pull request CesiumGS#9002 from CesiumGS/screenspaceeventhandlder-jsdoc
Fixes ScreenSpaceEventHandler.getInputAction JSDoc
2 parents 9d9ead3 + 09cbbd4 commit 3b54b9d

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed
 

‎CHANGES.md

+5-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
##### Breaking Changes :mega:
66

7-
- Updated `WallGeometry` to respect the order of positions passed in, instead of making the positions respect a counter clockwise winding order. This will only effect the look of walls with an image material. If this changed the way your wall is drawing, reverse the order of the positions.
7+
- Updated `WallGeometry` to respect the order of positions passed in, instead of making the positions respect a counter clockwise winding order. This will only affect the look of walls with an image material. If this changed the way your wall is drawing, reverse the order of the positions. [#8955](https://github.com/CesiumGS/cesium/pull/8955/)
88

99
##### Additions :tada:
1010

@@ -15,17 +15,18 @@
1515

1616
##### Fixes :wrench:
1717

18-
- Fixed issue where tileset was not playing glTF animations [#8962](https://github.com/CesiumGS/cesium/issues/8962)
18+
- Fixed issue where tileset was not playing glTF animations. [#8962](https://github.com/CesiumGS/cesium/issues/8962)
1919
- Fixed a divide-by-zero bug in `Ellipsoid.geodeticSurfaceNormal` when given the origin as input. `undefined` is returned instead. [#8986](https://github.com/CesiumGS/cesium/pull/8986)
20-
- Fixed error with `WallGeoemtry` when there were adjacent positions with very close values [#8952](https://github.com/CesiumGS/cesium/pull/8952)
20+
- Fixed error with `WallGeoemtry` when there were adjacent positions with very close values. [#8952](https://github.com/CesiumGS/cesium/pull/8952)
2121
- Fixed artifact for skinned model when log depth is enabled. [#6447](https://github.com/CesiumGS/cesium/issues/6447)
2222
- Fixed a bug where certain rhumb arc polylines would lead to a crash. [#8787](https://github.com/CesiumGS/cesium/pull/8787)
2323
- Fixed handling of Label's backgroundColor and backgroundPadding option [#8949](https://github.com/CesiumGS/cesium/8949)
24-
- Fixed several bugs when rendering CesiumJS in a WebG 2 context. [#797](https://github.com/CesiumGS/cesium/issues/797)
24+
- Fixed several bugs when rendering CesiumJS in a WebGL 2 context. [#797](https://github.com/CesiumGS/cesium/issues/797)
2525
- Fixed a bug where switching from perspective to orthographic caused triangles to overlap each other incorrectly. [#8346](https://github.com/CesiumGS/cesium/issues/8346)
2626
- Fixed a bug where switching to orthographic camera on the first frame caused the zoom level to be incorrect. [#8853](https://github.com/CesiumGS/cesium/pull/8853)
2727
- Fixed `scene.pickFromRay` intersection inaccuracies. [#8439](https://github.com/CesiumGS/cesium/issues/8439)
2828
- Fixed a bug where a null or undefined name property passed to the `Entity` constructor would throw an exception.[#8832](https://github.com/CesiumGS/cesium/pull/8832)
29+
- Fixed JSDoc and TypeScript type definitions for `ScreenSpaceEventHandler.getInputAction` which listed incorrect return type. [#9002](https://github.com/CesiumGS/cesium/pull/9002)
2930

3031
### 1.70.1 - 2020-06-10
3132

‎Source/Core/ScreenSpaceEventHandler.js

+2
Original file line numberDiff line numberDiff line change
@@ -969,6 +969,8 @@ ScreenSpaceEventHandler.prototype.setInputAction = function (
969969
* @param {Number} [modifier] A KeyboardEventModifier key that is held when a <code>type</code>
970970
* event occurs.
971971
*
972+
* @returns {Function} The function to be executed on an input event.
973+
*
972974
* @see ScreenSpaceEventHandler#setInputAction
973975
* @see ScreenSpaceEventHandler#removeInputAction
974976
*/

0 commit comments

Comments
 (0)
Please sign in to comment.