Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: build and run FFI examples #158

Open
4 tasks done
hhirtz opened this issue May 18, 2022 · 1 comment · Fixed by #214
Open
4 tasks done

CI: build and run FFI examples #158

hhirtz opened this issue May 18, 2022 · 1 comment · Fixed by #214
Milestone
Version v0.2

Comments

@hhirtz
Copy link
Member

hhirtz commented May 18, 2022 •
edited
Loading

PR #131 made the CI fail because code coverage for the FFI isn't taken into account.

  • build the examples in ffi/examples/
  • build coupe-ffi with coverage instrumentation
  • run the examples with coverage and send it to codecov
  • update the rcb example to abort or return 1 when a coupe algorithm fails (done in More docs #181)
@hhirtz hhirtz mentioned this issue Sep 16, 2022
Merged
@hhirtz
Copy link
Member Author

hhirtz commented Nov 30, 2022

I don't know why, but some functions like coupe_data_array of coupe_adjncy_free aren't covered. Weird since the functions calls aren't inlined by clang or anything.

@hhirtz hhirtz reopened this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version v0.2
Development

Successfully merging a pull request may close this issue.

ci: build and run FFI examples for coverage LIHPC-Computational-Geometry/coupe
2 participants
@cedricchevalier19 @hhirtz