Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSAPy v1.0.0 not properly closing the lunar harmonics file? #1

Open
aperloff opened this issue Apr 17, 2024 · 1 comment
Open

SSAPy v1.0.0 not properly closing the lunar harmonics file? #1

aperloff opened this issue Apr 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@aperloff
Copy link
Member

Describe the bug
It seems that SSAPy is opening file ssapy/data/de430.bsp multiple times and not closing it.

To Reproduce
too be filled in

Expected behavior
We expect that you can run any number of operations without SSAPy crashing due to having too many files open.

Output

File "<path to ssapy>/ssapy/body.py", line 294, in get_body
  File "<path to ssapy>/ssapy/body.py", line 171, in __init__
  File "<path to site-packages>/site-packages/jplephem/spk.py", line 47, in open
OSError: [Errno 24] Too many open files: '<path to ssapy>/ssapy/data/de430.bsp'

Desktop (please complete the following information):

  • OS: Linux
  • Version RHEL
@aperloff aperloff added the bug Something isn't working label Apr 17, 2024
@igoumiri
Copy link
Contributor

According to the docs, we need to call self.kernel.close(). To do that cleanly we would need to turn those classes into context managers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants