Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema for validation #161

Open
mcutshaw opened this issue Mar 20, 2024 · 2 comments
Open

JSON schema for validation #161

mcutshaw opened this issue Mar 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mcutshaw
Copy link
Collaborator

mcutshaw commented Mar 20, 2024

Is your feature request related to a problem? Please describe.
Currently we don't appear to have an included copy of the full JSON schema. Ideally we would be able to include a copy and programmatically compare against it for development work, potentially CI/CD tests and just general use for SBOM validation.

Describe the solution you'd like
We could use something like https://pypi.org/project/jsonschema/ in conjunction with including a JSON copy of the schema. I'd be happy to handle this one, however I would want to verify that there would be no issue including that additional dependency, the correct JSON schema to be included (and that we're able to include it), and any additional input.

Describe alternatives you've considered
None

Additional context
None

@mcutshaw mcutshaw added the enhancement New feature or request label Mar 20, 2024
@nightlark
Copy link
Collaborator

nightlark commented Mar 20, 2024

This sounds like it would probably be an optional dependency used for tests, which would be fine.

The only issue is that technically the CyTRICS schema hasn't been publicly released yet (in some sense, we just happen to have dataclasses that closely map to it and read/write a format that matches the schema).

@mcutshaw
Copy link
Collaborator Author

Understood, I'll look into this on my side and see what peoples thoughts are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants