Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with GPU version #3

Open
artuuuro opened this issue Jan 7, 2020 · 3 comments
Open

Bug with GPU version #3

artuuuro opened this issue Jan 7, 2020 · 3 comments

Comments

@artuuuro
Copy link
Collaborator

artuuuro commented Jan 7, 2020

GPU version has a bug which makes the results incorrect.
@artuuuro
Copy link
Collaborator Author

artuuuro commented Jan 7, 2020

Bug is related to compute language < 70.

@artuuuro
Copy link
Collaborator Author

artuuuro commented Jan 7, 2020

Changed default values as a workaround for the bug (temporary).
commit 14ef50d

@correaa
Copy link
Member

correaa commented Jan 8, 2020 •
edited
Loading

This calls for a regression test https://en.wikipedia.org/wiki/Regression_testing , that is an a posteriori test to not repeat the same bug in the future.

I recommend looking into Catch2 or Boost.Test to add a suite of tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artuuuro @correaa