-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version info syncing issues #408
Comments
I would vote for tags to |
I'm for bumpver and with a bump to an alpha version after cutting a release. Then in an MR to main when working a release in that branch cut to the release candidate tag, if desired an rc build could get pushed to pypi. |
for Kosh I use |
So in that case, what is setting those tags? Tags can be overwritten silently, which seems ripe for trouble vs keeping it in the toml file directly. Also, when you build a wheel with something like that what does the name get mangled into for installing? didn't think pep440 supported the '-' suffix on wheels. Is this mainly just the version users would see if they install from source (editable or otherwise)? |
yes pep440 does not like it, I think we would have to drop the commit hash. As far as the "tag" goes we have to trust ourselves that we don't mess with the tags. |
Currently we seem to have 3 sources of package version info which is not in sync:
__init__.py
is still on 1.1.9dev1I propose switching this to a single source and automating it if possible and potentially a different versioning scheme (dev tags). Importlib appears able to read from the pyproject.toml now, so I think that single source could be the toml file now. Additionally, there's a few interesting options for at least semi-automated version bumping:
Either one would likely be able to use hook into an automated tag creation since both have a version query on the cli.
Potentially bigger changes to the versioning scheme beyond just possible switching away from dev if jumping on an existing solution right away:
The text was updated successfully, but these errors were encountered: