Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subprocess in check_for_scheduler can also raise PermissionError #435

Closed
cfriedland5 opened this issue Jul 27, 2023 · 1 comment · Fixed by #436
Closed

subprocess in check_for_scheduler can also raise PermissionError #435

cfriedland5 opened this issue Jul 27, 2023 · 1 comment · Fixed by #436
Labels
bug Something isn't working

Comments

@cfriedland5
Copy link

In get_batch_type when checking for pbs check_for_scheduler raised an uncaught exception because the subprocess raised a PermissionError rather than a FileNotFoundError.

The different exception was caused by me uncritically using a .bashrc file that added directories I didn't have permissions for to my path, but for Merlin's purposes I think it makes sense to proceed with checking for the existence of the other schedulers.

I'm know I'm not following the issue template but I think there's enough info to understand what's going on. Please let me know if you need more.

@cfriedland5 cfriedland5 added the bug Something isn't working label Jul 27, 2023
@bgunnar5
Copy link
Member

This was brought to my attention by another user previously too. I'll make sure to add a fix for it soon. I think it should be sufficient to just add another exception catcher for the PermissionError but I'll have to look into it a bit more before making a final decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants