Initial discrete adjoint capability with ERK #559
+18,916
−428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Steven Roberts <roberts115@llnl.gov>
balos1
requested review from
gardner48,
cswoodward and
drreynolds
as code owners
drreynolds
reviewed
Aug 27, 2024
Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
drreynolds
reviewed
Nov 13, 2024
Comment on lines
51
to
56
| # "ark_test_erkadjoint.cpp\;--check-freq 1 --no-stages\;" | ||
| # "ark_test_erkadjoint.cpp\;--check-freq 2 --no-stages\;" | ||
| # "ark_test_erkadjoint.cpp\;--check-freq 5 --no-stages\;" | ||
| # "ark_test_erkadjoint.cpp\;--check-freq 1 --dont-keep --no-stages\;" | ||
| # "ark_test_erkadjoint.cpp\;--check-freq 2 --dont-keep --no-stages\;" | ||
| # "ark_test_erkadjoint.cpp\;--check-freq 5 --dont-keep --no-stages\;" |
There was a problem hiding this comment.
Should these just be deleted from the file instead of commented out?
Suggested change
| # "ark_test_erkadjoint.cpp\;--check-freq 1 --no-stages\;" | |
| # "ark_test_erkadjoint.cpp\;--check-freq 2 --no-stages\;" | |
| # "ark_test_erkadjoint.cpp\;--check-freq 5 --no-stages\;" | |
| # "ark_test_erkadjoint.cpp\;--check-freq 1 --dont-keep --no-stages\;" | |
| # "ark_test_erkadjoint.cpp\;--check-freq 2 --dont-keep --no-stages\;" | |
| # "ark_test_erkadjoint.cpp\;--check-freq 5 --dont-keep --no-stages\;" |
Comment on lines
514
to
521
| // TODO(CJB): figure out why ForwardDiff, CVODES, and ERK adjoint all differ | ||
| // if (check_sensitivities_backward(sf)) | ||
| // { | ||
| // fprintf(stderr, | ||
| // ">>> FAILURE: adjoint solution does not match correct answer\n"); | ||
| // return -1; | ||
| // }; | ||
| // printf(">>> PASS\n"); |
There was a problem hiding this comment.
Is this "TODO(CJB)" still relevant, or should the comment and associated code be deleted?
balos1
changed the title
|
/autofix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.