Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse box problem #510

Closed
swisherh opened this issue Oct 28, 2015 · 6 comments
Closed

Browse box problem #510

swisherh opened this issue Oct 28, 2015 · 6 comments
Assignees
Labels
CMF Classical modular forms
Milestone

Comments

@swisherh
Copy link
Contributor

When you put something inappropriate into a search box, instead of letting you know as in the elliptic curves page, it gives a server error.
http://beta.lmfdb.org/ModularForm/GL2/Q/holomorphic/ranges?level=r&weight=&character=0&Submit=Search
gives a TypeError: coercing to Unicode: need string or buffer, int found

@swisherh swisherh added the CMF Classical modular forms label Oct 28, 2015
@swisherh swisherh added this to the v1.0 milestone Oct 28, 2015
@AurelPage
Copy link
Member

In the refactor branch, this is not fixed, but it is now a ValueError: invalid literal for int() with base 10: 'r'.

@AurelPage
Copy link
Member

This issue actually refers to the browse box (there is no search box yet).

@davidfarmer davidfarmer changed the title Search box problem Browse box problem Dec 15, 2015
@JohnCremona
Copy link
Member

After looking at this I have the strong opinion that it should NOT be fixed except by replacing all the custom parsing functions used to process the form input by central standardised ones.

@JohnCremona JohnCremona modified the milestone: v1.0 Dec 18, 2015
@sanni85
Copy link
Contributor

sanni85 commented Mar 31, 2016

The new parsing functions have not been applied for classical modular forms yet. So these errors do still occur.

@fredstro
Copy link
Contributor

fredstro commented Apr 1, 2016

If I knew how to apply the new parsing functions I would do that but they seem to be completely undocumented and I can't figure out how to use them or if they are even in a state that they could be used.
Since I didn't scroll down far enough to see John's comment that this shouldn't be fixed I went ahead and fixed it but I can just refrain from doing a pull request...

@davidfarmer davidfarmer removed the April label May 2, 2016
@AndrewVSutherland
Copy link
Member

This is fixed as of PR #1465 (possibly earlier), closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMF Classical modular forms
Projects
None yet
Development

No branches or pull requests

7 participants