Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B+B plays extra bar with note near the end #1105

Closed
kmouse opened this issue Aug 27, 2014 · 8 comments
Closed

B+B plays extra bar with note near the end #1105

kmouse opened this issue Aug 27, 2014 · 8 comments

Comments

@kmouse
Copy link

kmouse commented Aug 27, 2014

I have a beat with a drum note very close to the end of the bar (although it doesn't touch).
B+B
As you can see, the arrow showing what is playing is in the next bar.
What I found more interesting is that If I add normal note to any point in the bar, it loops normally.
B+B
Thanks

@tresf
Copy link
Member

tresf commented Aug 27, 2014

@kmouse can you give us some more details?

  1. For starters, which version.
  2. Secondly the platform.
  3. Last, I assume you can reproduce this on a new project? (or just an existing one?) If you can do it on a new project, can you please give us exact instructions to reproduce it? The screenshots are great, but people use the piano roll in this fashion all day long and this is the first I've seen this bug documented in our tracker. If you can only reproduce on an existing one, we'll have to find a way for you to upload the project to the tracker (saving as .mmp and putting on gist is a nice way to upload it for us).

@musikBear
Copy link

confirm 1.093 win x32 - i belive this is a result of the way no-length notes are placed in BB. Default we have 16 'places' for notes (4/4)
If a note is placed on 16th spot, it will be on the 4. tick in 4. beat
That loops perfectly
If the note however is moved to the right 1/2 a tick (Q 32), then the loop will eronious include 2. bar
So no-length-notes are 'surposed' to be at the tick start. If its not, the logic is broken.
This is not a problem in respect to swing-note patterns, (notes moves to the left - Im not sure where 'fraction-tick-notes' are needed, and in fact the problem only exists with no-length-notes, so if fractions are nedded, a fraction normal-note could be used - Not sure if a fix really is needed..?? (it has always been like this -right??

@tresf
Copy link
Member

tresf commented Aug 27, 2014

#843 #958

@Umcaruje
Copy link
Member

Umcaruje commented Jul 2, 2015

Reproduced on Ubuntu 15.04 x64, lmms 1.1.3

@zonkmachine
Copy link
Member

@kmouse @Umcaruje @musikBear
Could any of you please see if #2491 affected this anyhow?

@musikBear
Copy link

@zonkmachine
kmouse / Umcaruje can properly do that, but i need a binary for win32 to do it.

@zonkmachine
Copy link
Member

OK. We'll soon have a new RC build for you to test.

@zonkmachine
Copy link
Member

Could any of you please see if #2491 affected this anyhow?

It didn't...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants