Exclude tracks from master pitch

[kpone33]

It would be nice to be able to exclude specific tracks from being transposed by the master transpose slider on top of LMMS. Drum samples or Drumloops don't necessarily need to be transposed, so it would be very nice if one could say that a track will not be transposed by the global transpose.

[tresf]

Thanks for the feedback.

Do you mean the master pitch?

[kpone33]

@tresf Yep, exactly.

[Sti2nd]

Yeees, you just put words on a thought I never managed to formulate 👍

[diizy]

Yes, this can be a thing, just need to figure out where to put the UI.

[tresf]

@diizy would your recommend doing this on a global track level, or plugin-by-plugin? For example, the examples he mentions would only affect sample track and afp.

-Tres

[diizy]

On 11/24/2014 06:07 PM, Tres Finocchiaro wrote:

@diizy https://github.com/diizy would your recommend doing this on a
global track level, or plugin-by-plugin?

Definitely on instrument track. No idea yet where to put the GUI though.

[tresf]

If and when our Sample Track gets the instrument track widget, we could simply have a break inheritance icon next to pitch (apologies for the terrible mockup)

[diizy]

On 11/24/2014 06:52 PM, Tres Finocchiaro wrote:

If and when our Sample Track gets the instrument track widget, we
could simply have a |break inheritance| icon next to pitch (apologies
for the terrible mockup)

Why sample track? We don't even have pitch control for sample tracks?

[tresf]

Why sample track? We don't even have pitch control for sample tracks?

Yes, I should have tried before making that statement. I was unaware that SampleTrack was unaffected by master pitch. Touché. I'll rephrase:

we could simply have a break inheritance icon next to pitch (apologies for the terrible mockup)

⛄

-Tres

[Sti2nd]

Diizy have a point that track edits is easier/logical and faster to edit on the track itself.

[diizy]

On 11/24/2014 09:00 PM, Tres Finocchiaro wrote:

we could simply have a break inheritance icon next to pitch
(apologies for the terrible mockup)

Sure, that could work. Can't think of anything better myself, anyway.

[curlymorphic]

If and when our Sample Track gets the instrument track widget, we could simply have a break inheritance icon next to pitch (apologies for the terrible mockup)

How about an LedCheckBox, or do we already have link/unlink icons. in thinking about ui consistency?

[Sti2nd]

How about an LedCheckBox

Depends where you want it? I think it could become very little space in the instrument track if both a new LED and indention is going to be a reality #735

[curlymorphic]

I was more refering to this mock up from tres , sorry should have said that

[softrabbit]

Can't say I have a better place for it, but a button next to (and grouped with) the pitch knob and range selector looks to me like it would turn off the instrument pitch bending and not just ignore master pitch.

[tresf]

Can't say I have a better place for it, but a button next to (and grouped with) the pitch knob and range selector looks to me like it would turn off the instrument pitch bending and not just ignore master pitch.

Good point. Can we have Green (inherited) Yellow (non inherited) and Off/Red (disabled) ?

[curlymorphic]

Good point. Can we have Green (inherited) Yellow (non inherited) and Off/Red (disabled) ?

Im confused, i dont understand the inherited state.

I though an instrument was to follow global pitch or not, I obviously am missing something?

[tresf]

I though an instrument was to follow global pitch or not, I obviously am missing something?

Yes it should. @softrabbit's point is that such an LED may be suggestive of enabling/disabling pitch entirely. I was simply proposing a way to help although we don't really have 3-state LEDs yet... 😕

[curlymorphic]

But i simply dont understand the 3 states? sorry

anyway a quick screenie of what I have

Do we need txt? the Led control has no label
Is it in the right place?

[tresf]

State 1 - Pitch is enabled and inherited from master pitch
State 2 - Pitch is enabled but inheritance is broken from master pitch
State 3 - Pitch is disabled completely

[curlymorphic]

Now I understand.

Is this a real need though, the disabling of pitch, as pitch is applied on a track by track basis.
I feel a tri state could be confusing, and inconsistent.

[Spekular]

I think a led next to the pitch knob or somewhere in that area is clear
enough as long as it has a hover text explaining it. There also seems to be
room for two leds (vertically), so there could be one for "inherit master
pitch" and one for "enable pitching", both on by default.

[tresf]

Is this a real need though, the disabling of pitch, as pitch is applied on a track by track basis.
I feel a tri state could be confusing, and inconsistent.

Good point. Shall we do green/yellow then? I still tend to agree with @softrabbit that the "off" indicator is misleading when directly besides those components.

[curlymorphic]

Shall we do green/yellow then?

The only problem with that, iirc is our LedCheckBox's only use 1 color.

[tresf]

Yes good point... it appears to be hard-coded with the off pixmap. We can worry about aesthetics later I suppose.

https://github.com/LMMS/lmms/blob/master/src/gui/widgets/LedCheckbox.cpp#L119

[curlymorphic]

Wll this was done ages ago, except for labeling.

LedCheckBox has no label, or hint text.

If i place a label below the checkbox, there is insufficent space for any meaningful text.

[softrabbit]

There's room for one more tab in the instrument settings, maybe that should be created and this pitch switch thing could go there?

[curlymorphic]

LedCheckBox has no label, or hint text.

well making silly claims like that publicly jolted my brain

thats with mouse over the check box, (sorry screen shot dont show cursor)

There's room for one more tab in the instrument settings, maybe that should be created and this pitch switch thing could go there?

A tab just for a checkbox?

[softrabbit]

A tab just for a checkbox?

It may sound like overkill, but sooner or later there'll be something else that needs a checkbox or knob that doesn't fit in the other tabs, so why not stake out some territory for expansion. Call it "MISC" or something like that.

[curlymorphic]

sure

[tresf]

It may sound like overkill, but sooner or later there'll be something else that needs a checkbox or knob that doesn't fit in the other tabs, so why not stake out some territory for expansion. Call it "MISC" or something like that.

Sorry, late to the convo, but I think this is cleaner and less confusing. 👍

[tresf]

Closed via #1593