-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placeholder folders (and files) in user directory for Ladspa, VSTs, themes and templates #1541
Comments
👍 As a user who can't always paste to the install directory (stupid |
No they don't. I'm not sure how you've setup your workstation, but this isn't true at all, user defined folders can and should be used for all customizations to the Themes, LADSPA effects plugins, VST effects plugins, etc. If there is something confusing about how we have it today then please share so that we can improve it. -Tres |
OMG. Yes, placeholder would be better! So basically placeholder folder for each of those paths. |
👍 If you could make a mock-up of what the structure would look like, that would help. We can append it to the original post as well. |
I don't know about the GIG or lv2 folder. I found out that there isn't really a default folder for soundfonts, only the default soundfont file, so if there are going to be a folder, there first need to be a setting. Would be useful so you didn't have to browse from your user/lmms/sample to the correct path all the time. |
Yeah, I agree... We need some consistency here... I think a folder called "plugins" would be better and then inside there have something like "vsteffect", "ladspaeffect", "vstinstrument", etc. Soundfonts are a bit of a gray area between samples and plugins, but I wouldn't be opposed to having them in the plugins folder too. Once decided, what this does is gives us the ability to treat plugins like plugins and have the items show up in the GUI without as much guess work. First we would need to determine this folder structure, which I think you've done a good job of starting. Thanks for the mockup. |
Also, the other issue is that a good portion of VSTs are installed to Program Files, so I'm not sure how to accommodate those from a "show up in the GUI" perspective. Is there a centralized registry/list we can read from in Windows which lets us know about which VSTs should be available to the system? |
Note that lv2 and ladspa folders are probably not necessary for linux, because IIRC LMMS (and carla) look up |
I think this is the major problem on Windows (or simply with VSTs in general), there's no default installation location for such plugins. |
Well, I wouldn't know with commercial ones, I copy what I need (which usually is only licence and .dll file) over to my VST or VSTi folder on my external hard drive. I rarely download executable files, for me it is mostly extracting an archive to get a folder with the VST.
http://forum.cakewalk.com/Install-VST-plugins-in-Program-Files-or-Program-files-x86-m2072089.aspx
Ladspa folder is needed for Windows, though. Adding those folders won't change anything, it will just enable the user to use an online service to automatically back up everything. As in all your VSTs, samples, presets, projects, non-native Ladspa effects, and so on. (I know this can be done already, lol) That LMMS allows working with different DAWs is neat and should be kept, of course, this won't ruin anything. |
The point is so that the user don't have to access the installation directory at all. So with the ladpsa both files in the user ladspa folder and the installion directory ladspa folder will show up. Yes to theme folder and have a folder default which links to the default theme. Alternatively a reset theme button in the settings? I am not sure aboutt the GIG folder myself, but as with the SoundFont File it would be great to be able to set a location which opened when you click on the folder icon to browse for sf2 or gig files. So it doesn't necessarily have to be a folder within LMMS, but for simplicity it might as well be. This also applies to VSTi files / VeSTige. I find it a bit annoying that you have to set VST path for LMMS to show VSTs in the effect browser, and that same setting is also the path for VST instruments. Yeah, recursive scan of VSTs is perhaps the best. (Can you then differ between effects and instruments?) You can already add several paths in the settings, so if it is hard to implement I wouldn't stress it. What I would stress is to differ between VST effect paths (used by LMMS to populate the effects window) and VST instrument path (could be used as default location when opening files with VeSTige).
Yes. And Lv2 I don't know anything about. Carla is the plugin that opens it so that plugins should perhaps take care of everything lv2 for now. |
Some thoughts:
-Tres |
Agreed. This is a crucial step in this improvement in my opinion. |
From the other thread:
Since SF2's can be dragged from the sample browser, I don't think there is a need for this folder (I'd never use it, idk about others)
Hmm yeah this would be the only benefit for a SF2 folder perhaps.
I think LMMS should make this seperation, not the user. Those are my thoughts. |
Agreed... just not sure how much work that is... :) |
Do you think SF2s should just be bundled along with the samples? Edit: With that argument, VSTs would be the same (no?) They can also be dragged from the file browser. |
Well, SF2 and GIG's are sample libraries after all, it makes sense. I keep my SF2's in my samples folder. Also, what do you mean by 'bundled'? There is an idea of having SF2 inside the sample library? |
I meen we should ship the software with small, basic CC0 soundfont. It will also help unit testing. |
I will look into the details this evening time permitting. but yes. iirc the process follows these lines
When effects and instruments are loaded, the user is presented with the correct list from our datastore. This also means the vst can be flagged as unworking and not presented, or loaded inside a project, causing it to hang, (although that is another issue that needs looking at). It is usual to give the user an option to force a clean rescan. Ive probably missed out a few details, but thats the basics |
True, so since there is a folder button, there is a need for a setting that let you choose what folder the button open. |
Reading through this I feel this may be better broken down into smaller projects, To aid in development and pull requests.
@tresf does splitting this up sound reasonable to you? |
Absolutely. Would you be opposed to creating a bug report that you own and can add/update as needed? That way you can cross off the items (rather than having a project admin continuously editing this one)? Once that's open, we'll mark this as duplicate and use yours as the master topic. Does that sound reasonable? |
That is an excellent idea :) |
Marking as duplicate of #1807 (a WIP placeholder). If we missed something over there, please post in the comments! |
I believe the working directory could be the only place the user needs to care about. Currently the user has to access the installation directory to paste new themes and Ladspa effects.
Proposal: Ladspa effects, themes, VST effects, SoundFonts and GIG files? get a folder in user directory, just like the user presets have. The path in settings would default to this folder, the user can still change the path of course. Templates get a folder in the project folder?
The text was updated successfully, but these errors were encountered: