Tab MISC | 'Enable the use of Master-pitch' Diodes has slave behavior

[musikBear]

PR 17. feb. g23d284 win32

To reproduce:
Insert any number of presets or sample tracks in B&B-editor
Add some notes.

Open top-track
Go to MISC.
Toggle the diode for MASTER-PITCH
Open any track below the top track
The diode for MASTER-PITCH will have changed to the value of the top-track as a slave.

Does current windows Master (still) have this behavior?

Demofile: https://lmms.io/lsp/download_file.php?file=8152&name=masterpitchErrors.mmp

Edit: Similar issue closed as duplicate: #2613

[zonkmachine]

There's absolutely something fishy here. Is this only in a Beat track?

[musikBear]

@zonkmachine ..dont know why i did not test that too 🔎
No, song-editor has the same bug.

[zonkmachine]

I got a crash while probing this that could be related. 🍺

backtrace
bt full

[zonkmachine]

@curlymorphic This issue is related to #1593 and #1597 . Turning "Enables the use of Master Pitch" on/off affects other instrument tracks than the intended in an unpredictable way.

[zonkmachine]

It looks like this could be related to song-global automation.

[musikBear]

@zonkmachine #403 -i vote remove

[PhysSong]

@musikBear Can you still reproduce it?

[zonkmachine]

Well, I could a month ago.

[PhysSong]

@zonkmachine What was the revision?

[zonkmachine]

Replicated on stable-1.2 b3054fd with the test project in the first post.

[PhysSong]

@zonkmachine Can you test with latest master?

[zonkmachine]

Tested on latest master. Bug still around.

[zonkmachine]

Closed. Fixed by @serdnab in #3753 and backported to stable-1.2 in 94646e2.