Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Pattern size is not updated when it is altered by changing note length #2660

Closed
Fastigium opened this issue Mar 10, 2016 · 2 comments
Assignees
Milestone

Comments

@Fastigium
Copy link
Contributor

Commit fcec8dd causes a regression in the drawing of Patterns on the song editor. To reproduce, enlarge any last note in a piano roll so that the Pattern becomes at least one measure longer. Now look at the song editor and notice that the Pattern still has its old length.

@Umcaruje As this is your commit, could you look into this regression? Let me know if you have trouble reproducing it.

@musikBear
Copy link

FYI enlarging last notes in tresf' qt5-build for xp, does enlarge the song-editor-block correctly. Eg, i could not reproduce on lmms-1.1.90-win32-qt5
I enlarged 1/16 from 1. to 4. tick to 2/4/6 and 8 bars length. The blocks were sized accordingly, both in enlarging and shortening.

@Umcaruje
Copy link
Member

@musikBear this was caused by a commit I pushed yesterday, it couldn't have been in your build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants