Zoom button has inverted functionality

[karmux]

This issue is about Piano Roll, Automation Editor and Song Editor. Before it worked same way as in wiki: https://lmms.io/documentation/Song_Editor#Zoom_Control

Scenario 1: For example in piano roll current zoom is 100%. To see notes a little bit closer I want to zoom in. I use mouse left button to click the "100%" button. I expect piano roll to zoom in because in most programs (Audacity etc) left mouse click zooms in. LMMS zooms out instead.

Scenario 2: For example in piano roll current zoom is 100%. To see all notes I want to zoom out. I use mouse right button to click the "100%" button. I expect piano roll to zoom out because in most programs right mouse click zooms out. LMMS zooms in instead.

This bothers me a lot. Before I make a pull request I want to be sure it's a bug not a new feature.

Ctrl + mouse scroll has expected behaviour (fixed in #3273).

[Umcaruje]

I agree on this 👍

[zonkmachine]

Before I make a pull request I want to be sure it's a bug not a new feature.

👍 Please fix this.

[karmux]

This bug was introduced by #3273. I reverted it and fixed scrolling in a different way. Now zooming works correctly with both mouse scrolling and mouse clicking.

[zonkmachine]

This bug was introduced by #3273. I reverted it and fixed scrolling in a different way. Now zooming works correctly with both mouse scrolling and mouse clicking.

You can scroll the zoom combo box or 'Ctrl + scroll' the window you want to zoom. With your fix the scrolling action now works in opposite directions for these two options. This was one of the things I tried to fix in #2517.

[karmux]

@zonkmachine ctrl + scrolling windows is still working as expected. If you look changes of my PR you see I switched -- and ++ there.

About scrolling zoom combobox you are correct. Forgot that I can scroll it. But it seems to be consistent with other comboboxes now if clicking or scrolling on it. What about reverse sorting items in combobox so that 800% is on top and 12.5% is on bottom? In this way all combobox actions are consistent and zooming works as expected from every place.

[Umcaruje]

What about reverse sorting items in combobox so that 800% is on top and 12.5% is on bottom? In this way all combobox actions are consistent and zooming works as expected from every place.

👍

[karmux]

What about reverse sorting items in combobox so that 800% is on top and 12.5% is on bottom? In this way all combobox actions are consistent and zooming works as expected from every place.

Actually this wouldn't make anything better but again inverts zooming when clicking and that is what #3570 is trying to fix.

I'd leave PR as it is right now since:

• ctrl + scrolling windows works in correct way
• clicking on zoom combo box works in correct way
• scrolling zoom combo box options works exactly like scrolling Q, scale, chord or any other combo box options

[musikBear]

@karmux

but again inverts zooming when clicking and that is what #3570 is trying to fix.

That was my thought too, one thing that perhaps could be an improvement in selects, was to let them loop. Ive done that in AS3 for scaling of things like text, and it is often a help to get to the wanted value faster. -Up to you :)

[zonkmachine]

Actually this wouldn't make anything better but again inverts zooming when clicking and that is what #3570 is trying to fix.

///

I'd leave PR as it is right now since:

• ctrl + scrolling windows works in correct way
• clicking on zoom combo box works in correct way
• scrolling zoom combo box options works exactly like scrolling Q, scale, chord or any other combo box options

If you want the scroll to work in the same direction you could stop inverting the action on 'Ctrl + WheelEvent'. I'd rather see the action be the other way if it's possible but at least this way they would work the same direction. In any case it's not a big deal for me and I'm happy to see it the same way as in 1.1.3 .

... one thing that perhaps could be an improvement in selects, was to let them loop. Ive done that in AS3 for scaling of things like text, and it is often a help to get to the wanted value faster. -Up to you :)

That would be too confusing for me. I like the scroll to stop at the end points.