Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LcdSpinBox Inconsistency with "4" #3821

Closed
ghost opened this issue Sep 23, 2017 · 9 comments
Closed

LcdSpinBox Inconsistency with "4" #3821

ghost opened this issue Sep 23, 2017 · 9 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Sep 23, 2017

If you edited/looked at the custom Lmms numbers you would notice the the "4" is by 1 pixel off unlike the others :
image

I know its 1 pixel but it still looks weird. Here is how it should look like :
image
Also here is the download for the fixed version : http://www.mediafire.com/view/8a43g4wa6sk2g5z/lcd_19green.png

Also we could get rid of the other LCD numbers since i find them useless.

(Also sorry if this issue has been brought up before. I could not find any.)

@tresf
Copy link
Member

tresf commented Sep 23, 2017

@Texxiliator this should be patched for all versions of our LCD. If you submit a pull request, we'd happily accept it. https://github.com/LMMS/lmms/tree/stable-1.2/data/themes/default

@BaraMGB
Copy link
Contributor

BaraMGB commented Sep 23, 2017

Can you please provide a pull request for the correct png?

@ghost
Copy link
Author

ghost commented Sep 23, 2017

Ok
But what is the pink lcd used for? @tresf

@tresf
Copy link
Member

tresf commented Sep 23, 2017

@Texxiliator I don't believe the others are being used by the codebase, but until we pull support for them we should keep them consistent.

@tresf tresf changed the title The "4" LcdSpinBox Inconsistency with "4" Sep 23, 2017
@ghost
Copy link
Author

ghost commented Sep 24, 2017

@tresf We could also rename the lcd_19pink.png to lcd_19purple.png since thats the actual color. Or we could change it a little bit to be more pink and use it for SF2 Player.

@Umcaruje Umcaruje added the gui label Oct 2, 2017
@Umcaruje
Copy link
Member

Umcaruje commented Oct 2, 2017

This should be a change in the actual svg files over on LMMS/artwork as well. I'll look into this

@Umcaruje Umcaruje assigned Umcaruje and RebeccaDeField and unassigned Umcaruje Oct 2, 2017
@Umcaruje
Copy link
Member

Umcaruje commented Oct 3, 2017

@RebeccaLaVie is looking into the issue.

@RebeccaDeField
Copy link
Contributor

I have created a pull request for the short term alignment fix here #3864.

Longer term, all references to the additional LCDs should be removed as the primary green color is all that is necessary.

@zonkmachine
Copy link
Member

Fixed in #3864.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants