-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LcdSpinBox Inconsistency with "4" #3821
Comments
@Texxiliator this should be patched for all versions of our LCD. If you submit a pull request, we'd happily accept it. https://github.com/LMMS/lmms/tree/stable-1.2/data/themes/default |
Can you please provide a pull request for the correct png? |
Ok |
@Texxiliator I don't believe the others are being used by the codebase, but until we pull support for them we should keep them consistent. |
@tresf We could also rename the lcd_19pink.png to lcd_19purple.png since thats the actual color. Or we could change it a little bit to be more pink and use it for SF2 Player. |
This should be a change in the actual svg files over on |
@RebeccaLaVie is looking into the issue. |
I have created a pull request for the short term alignment fix here #3864. Longer term, all references to the additional LCDs should be removed as the primary green color is all that is necessary. |
Fixed in #3864. |
If you edited/looked at the custom Lmms numbers you would notice the the "4" is by 1 pixel off unlike the others :

I know its 1 pixel but it still looks weird. Here is how it should look like :

Also here is the download for the fixed version : http://www.mediafire.com/view/8a43g4wa6sk2g5z/lcd_19green.png
Also we could get rid of the other LCD numbers since i find them useless.
(Also sorry if this issue has been brought up before. I could not find any.)
The text was updated successfully, but these errors were encountered: