Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monstro's osc 3 vol knob always uses percentages. #3911

Closed
husamalhomsi opened this issue Oct 24, 2017 · 3 comments
Closed

Monstro's osc 3 vol knob always uses percentages. #3911

husamalhomsi opened this issue Oct 24, 2017 · 3 comments
Labels

Comments

@husamalhomsi
Copy link
Member

Monstro's osc 3 vol knob with the "Display volume as dBFS" setting enabled:
capture20171024164622676
image

It uses percentages instead of levels in dBFS.

@zonkmachine
Copy link
Member

The other volume knobs has line to set them explicitly as a volume knob.
m_osc2VolKnob -> setVolumeKnob( true );
Try adding a line like that for m_osc3VolKnob, may be all that's missing in there.

@husamalhomsi
Copy link
Member Author

husamalhomsi commented Oct 24, 2017

Tested your suggestion, it fixes the issue and works as expected. Will open a PR soon.
Which branch should I target, stable-1.2 or master?

@zonkmachine
Copy link
Member

Bug fix, stable-1.2 would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants