Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample track standalone recorder #3943

Open
Reflexe opened this issue Nov 5, 2017 · 5 comments
Open

Sample track standalone recorder #3943

Reflexe opened this issue Nov 5, 2017 · 5 comments

Comments

@Reflexe
Copy link
Member

Reflexe commented Nov 5, 2017

Hello guys,

I'm currently working on a standalone sound recorder for LMMS. Most of the code is already there (SampleRecordHandle). The only thing I've implemented is the actual recording for each device type (e.g. ALSA, JACK, ...).

Surprisingly, for JACK, it was pretty trivial so now JACK and PortAudio support recording and therefore support sample track recording too.

Just before I take another step, am I doing it right? Way was this feature disabled?

Thank you all :)

@tresf
Copy link
Member

tresf commented Nov 5, 2017

@Reflexe thanks for running with this! In regards to why the feature was removed, I don't think any of the current project maintainers were around when that decision was made. The feature was added 9 years ago by the original author, Toby but it appears to have been coded by Csaba Hruska: 1410f2b.

Thanks for the warm welcome. We're also over on Discord in the #devtalk channel if you wish to use that as a medium as well.

Related: #1471

@Reflexe
Copy link
Member Author

Reflexe commented Apr 15, 2021

OK. I think I learnt a few things in the last few years. One of which is how to manage tasks.

The output of this task should be a series of PRs that looks like:

  • Infra/Core modifications for recordings
  • Add recording support for a backend as a proof of concept

Afterwards, we will many ways to improve from:

  • Add recording to more backends
  • Add on-the-fly visualization support
  • Refactor recording to use a ringbuffer
  • Refactor SampleBuffer to use std::vector instead of the current mess
  • etc

I am currently looking on the code and trying to do some cherry-picking for the first stage (I have some free time finally :))

@qnebra
Copy link

qnebra commented Apr 15, 2021

I think "on-the-fly visualisation support" could be easier due to 'soon to be merged' @douglasdgi overhaul of how sample tracks are visualised.

@Reflexe
Copy link
Member Author

Reflexe commented Apr 15, 2021

@qnebra Can you please link the PR? Thanks

@LostRobotMusic
Copy link
Contributor

#5927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants