-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segfault on file open dialog. #4275
Comments
The recent files drop-down works fine, however, both |
I have just noticed that |
This seems to be an issue affecting all file dialogs; could be a issue with Qt though and not lmms. |
Shot in the dark.... https://bbs.archlinux.org/viewtopic.php?id=121360. From what I'm reading there are some buggy gtk themes which may be the culprit as well as some root Qt5 bugs. The crash is very clearly I also assume this same symptom occurs with the AppImage (https://lmms.io/download/#linux)? We build with a backport of the latest Qt5 (e.g. 5.9 or higher) so if a particular bug has been resolved along the way the AppImage would benefit from this. Here's one that sounds very similar in description (unresolved). Since it's against GTK2, it's not relevant to your setup (as your backtrace says you're on GTK3): Something a bit unique about our theme is that we theme most of our own common dialog boxes, so if you hit a theming bug it may be specific to Qt apps that override the default Qt theme. I'm not aware of any others off-hand although one Qt app that uses the default theme is Qt Linguist if you can baseline test against that. |
I'm starting to think my Qt/GTK installation is broken... The AppImage fails to start at all.
|
Can you try this one and see if it segfaults? The version from our download page had some linking errors with Jack which should now be resolved . #4094 |
If it matters, I'm running cinnamon as my DE. This could be an issue with gfx drivers, I recently did system update |
@noahb01 did the second AppImage segfault in the same fashion? |
Yup. Same error...
|
Last hack before I give up... what if you do |
This could be a Qt path error...
This application failed to start because it could not find or load the Qt platform plugin "xcb" in "". I know xcb is installed:
Anyways, even if the Also, I have tried rebooting/reloading the nvidia drivers; no effect. |
Most what I find online points to either missing Qt libraries or mismatched Qt libraries. I'm not sure what's causing this. We've tested our AppImage on Manjaro back in December without any issues. |
This could be a problem with my system and not lmms. Should |
Here's something interesting: |
It works fine as well if you |
Why that would affect the common dialog boxes is unknown to me. I suppose you could try to move the default path of Note, I did find an obscure issue with Arch and the cloud providers plugin, but the backtrace is quite a bit different. https://bbs.archlinux.org/viewtopic.php?id=232172 |
I have a feeling that the config window that opens on first launch does some setup code that isnt normally done, thus preventing the segfault. Once Update!! |
Oops wrong button |
Yeah that's not the themed dialog, that's the native one per this comment earlier...
Here's the dialog you're describing on Mac for example: Versus the File > Open dialog: |
Yes. My point is, by manually setting the working dir (either by |
It comes down to this: Themed file boxes do not segfault if you open a non-themed box first. After a non-themed box has been opened, themed boxes work without issue. |
Here's the custom FileDialog code if you want to hack at it... lmms/src/gui/dialogs/FileDialog.cpp Line 42 in 32f07ac
For example, you may be able to get a bit further by commenting out: setOption( QFileDialog::DontUseNativeDialog ); The code is pretty simple. I'm not sure exactly what could cause a crash inside it. Some more information on the Qt class that is used: http://doc.qt.io/qt-5/qfiledialog.html |
Commenting it out stops the segfault and everything works fine. I still don't know why it fails with the custom theme. |
Yup -- That's this bug. Can confirm that opening a non themed dialog stops segfaults:
Adding this code before |
If this is a GTK bug and not a LMMS bug, should we just close this issue and disable themed file boxes until it's fixed? |
If revering GTK fixes it, yes, we'd be inclined to close this out as |
Source of
And
Considering that dependencies can be difficult on Arch and that I've already had to reinstall one Arch box this week due to messed up dependencies, I'm not going to try and downgrade GTK on my system to test this. However, this definitely seems like a problem with either GTK or QT. (There are no segfaults if you compile with qt4 instead of qt5...) For now though, couldn't we just disable the custom theming on the file boxes? |
Theoretically, yes but we generally don't code workarounds to a specific platform unless it's something we can detect at runtime. I guess it would depend on the scope of this bug (which will naturally grow the longer that it goes un-patched). |
Considering that this is an upstream Qt/GTK bug and that it seems to only affect me, I'm closing this issue. If it causes trouble for anyone else, the current workarounds are:
If anyone finds a real fix to this issue, feel free to reopen it/make a PR to fix it. |
@noahb01... @Wallacoloo was kind enough to dig into this one and found #4280 which appears to be a bug with the utility we use for packaging. Can you test this AppImage and let us know if it fixes the segfault? Thanks @Wallacoloo for the research. https://github.com/tresf/lmms/releases/download/v1.2.0-rc5/lmms-1.2.0-rc5.43-linux-x86_64.AppImage Edit: On second thought... Due to the history and nature of this bug there's a good chance these two are unrelated entirely and that the new AppImage won't fix anything... I'll wait for some feedback. :) |
The new AppImage fixes the file chooser crash for me on Arch (likely because it bundles its own version of some Qt libraries). My setup is probably not identical though (e.g. running Wayland, not X11), so having confirmation would be a plus. |
The AppImage loads successfully and does not crash with the file-dialogs. It does, however, fail to find the LADSPA plugins Limiter and Reverb (used in the project file I used to test the dialog; they load fine in 1.2.0-rc5.277 compiled from source) |
There's a bit of a search-path bug with the LADSPA stuff too. For example... Edit: We may still be able to improve the search order for 1.2.0 to circumvent this bug. More information here: #3942 |
Does this also happens with newly created projects (created on this AppImage)?
Care to test with other plugins? |
That's on |
@noahb01 that makes more sense. Master has the If you need to, you can |
The new appimage above (lmms-1.2.0-rc5.43-linux-x86_64.AppImage) fixed this crash for me as well under Netrunner Rolling (Manjaro). |
When clicking the open file button, lmms crashes with a segfault.
This is the first run of a fresh build of lmms.
Build Instructions
Output
Backtrace
OS
If any other info is needed I will provide it.
The text was updated successfully, but these errors were encountered: