Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The oscilloscope color can't be changed #4459

Closed
Skynse opened this issue Jul 2, 2018 · 5 comments
Closed

The oscilloscope color can't be changed #4459

Skynse opened this issue Jul 2, 2018 · 5 comments

Comments

@Skynse
Copy link

Skynse commented Jul 2, 2018

Line 176 below, won't change the color of the background of the oscilloscope and it wont change the color of the sound waves

VisualizationWidget {
background: none;
border: none;
}

@PhysSong
Copy link
Member

PhysSong commented Jul 4, 2018

I suggest you to change output_graph.png file. It's the background image for the oscilloscope.

@josh-audio
Copy link
Member

@DevSynth Does this answer your issue?

@josh-audio josh-audio added the response required A response from OP is required or the issue is closed automatically within 14 days. label Jul 18, 2018
@Umcaruje
Copy link
Member

The color of the waveform display seems to be hardcoded:

if( max_level * master_output < 0.9 )
{
p.setPen( QColor( 71, 253, 133 ) );
}
else if( max_level * master_output < 1.0 )
{
p.setPen( QColor( 255, 192, 64 ) );
}
else
{
p.setPen( QColor( 255, 64, 64 ) );
}

So this is a valid enhancement request.

@Umcaruje Umcaruje added enhancement gui and removed response required A response from OP is required or the issue is closed automatically within 14 days. labels Jul 30, 2018
@Skynse
Copy link
Author

Skynse commented Jul 30, 2018

Changing output_graph.png doesn't do anything btw

@michaelgregorius
Copy link
Contributor

#4509 makes the line colors (normal, warning, clipping) available as properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants