Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang-note in zasfx #5220

Closed
musikBear opened this issue Oct 4, 2019 · 2 comments
Closed

Hang-note in zasfx #5220

musikBear opened this issue Oct 4, 2019 · 2 comments
Labels

Comments

@musikBear
Copy link

musikBear commented Oct 4, 2019

win10 1.2.0
First you should watch this:
https://youtu.be/Jx7jCNv4lAI
The behaviour was initiated as a arpeggio on E3 was playing, so i first found related to #320. @DomClark mean it is a different issue, and asks for a new bug-report -This is he....
Here is the file ZASFX_HangNoteProblem.zip
ZASFX_HangNoteProblem.zip

Recreate:
It is the note E3 that creates the hang. The arpeggio caused the issue, but arpeggio -replay is not mandatory to invoke the fail.
Just press E3, and that note hangs
Arpeggio' relation is only by chance: E3 is 'pressed' in the arpeggio sequence, and that the initiate the hang.
The Hang is terminated if:

  • Show-Gui button is pressed
  • Panic-button inside xasfx is pressed

The Hang is however not fixed. It returns if E3 is re-pressed.
I have tested on win1.2.0 and a Master ( 1.2.0RC7.263 ) Both with the bug, but in Master, only after 2. replay. To me that could indicate some kind of un-precise arpeggio termination signal for the note, but why then is the bug present as soon as E3 is pressed?

@musikBear
Copy link
Author

Has anyone worked on zasfx in 1.2.1 ?
This bug has disappeared!
I cant initiate this hang in 1.2.1 <3
It may be too soon to go Hoorayy yet, but i looks like 1.2.1 have this fixed. It is not mentioned in the releasenotes, that any work has been done on zasfx, so this could be a lucky strike
@DomClark Can you confirm?

@DomClark
Copy link
Member

I can't reproduce it in 1.2.1, although I found it difficult to reproduce in 1.2.0 so it may just be that I haven't managed to trigger it yet. However, since you could reproduce it reliably, and now you can't, I'll assume it's fixed and close this issue for now. We can reopen it later if the bug reappears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants