Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counterintuitive looping controls #6014

Closed
lookitsnicholas opened this issue May 11, 2021 · 11 comments
Closed

Counterintuitive looping controls #6014

lookitsnicholas opened this issue May 11, 2021 · 11 comments
Assignees

Comments

@lookitsnicholas
Copy link

lookitsnicholas commented May 11, 2021

relates to #4034 and #5505 - not really sure why this needs to be separate, tbh

Bug Summary

As explained here, many people have expressed issues with the new control scheme for creating loops because it implicitly discourages changing parameters for larger projects due to the new additional amount of input required in order to do so.

Steps to reproduce

Create a loop of 100 measures, and try to move the loop end point to measure 50. Additionally, attempt to create a four-bar loop and move the end of the loop to the start of measure two.

Expected behavior

Something analogous to the original behavior, with one right-click/two-finger tap to end the loop and Shift+(right-click/two-finger tap) to start the loop.

Actual behavior

Weirdness due how the mean calculations are implemented... the video below shows the inability to end the loop at measure 50, and how incremental decrements of the loop length are currently required to shrink a four-bar loop into one. Zooming out is not an acceptable workaround because the resolution of said changes drops significantly, resulting in potentially more needed clicks.

Recording

Screen.Recording.2021-05-11.at.1.46.40.AM.mov

Affected LMMS versions

Anything recent on 1.3-alpha

Feedback

My input on this is that this change is breaking mine and others' workflows because of the unnecessary amount of time clicking around and zooming in order to achieve the same result. A suggestion would be to either revert this behavior, add an option to toggle to eliminate extra button presses to accommodate the original behavior, or at the very least the addition of Shift modifiers (Shift+LMB for the start of a loop and Shift+RMB for the end of a loop) to get rid of the movement now required to quickly change loop parameters.

@oldcastlehq
Copy link

I'm second to this. It's not only unintuitive, but it makes your work on LMMS harder.

@lookitsnicholas lookitsnicholas changed the title Unintuitive looping controls Counterintuitive looping controls May 11, 2021
@Spekular Spekular self-assigned this May 15, 2021
@Spekular
Copy link
Member

incremental decrements of the loop length are currently required to shrink a four-bar loop into one.

For the record this is false. Simply click anywhere on the right half to select the endpoint and then drag it left until the loop is one bar long.

@lookitsnicholas
Copy link
Author

Technically...? On a MacBook, that would consist of zooming out by scrolling on the zoom list box + Control+click + dragging the loop end point to the desired destination - that does not necessarily address the left point in that instance, which would also require zooming out. The point remains that that extra step of zooming out is now suddenly required when the previous implementation/other DAWs would allow for at most two-click operation.

@0xf0xx0
Copy link
Contributor

0xf0xx0 commented May 28, 2021

Technically...? On a MacBook, that would consist of zooming out by scrolling on the zoom list box + Control+click + dragging the loop end point to the desired destination - that does not necessarily address the left point in that instance, which would also require zooming out. The point remains that that extra step of zooming out is now suddenly required when the previous implementation/other DAWs would allow for at most two-click operation.

I agree, I have to move back and forth in the piano roll to move the loop when I wanna loop a specific bar later in the song. It's annoying at best, and it really sucks.

@Xeno-Idaltu
Copy link

Its been more than a year and still no changes to this annoying feature.. -__-*

@RiedleroD
Copy link
Contributor

the devs are almost done with the reorg. Have patience, young padawan.

@RoxasKH
Copy link
Contributor

RoxasKH commented Apr 15, 2022

Honestly even if there are people complaining that doesn't there aren't people who like it. I'd personally focus on making better the new system rather than purely revert the PR.

In my point of view the new system is way more intuitive to the newbie users, and other daws use the same system as well.

This is just for saying that probably a poll would be needed, as it's clear that people that don't like it would complain, but people that actually like the new system won't even think about saying somwhere they like it.

That said, i know it can be less comfortable in some situations, but it can also be more comfortable in some other situations, it just requires to change the workflow you're used to, and it shouldn't be so difficult as we learned how to use a daw from zero (and if you use multiple daws, you'd also be more flexible).
Now i'm not saying you aren't allowed to not like it obviously, i'm just saying that as it's present only in the alpha build, not even all the userbase have had the chance to try the new system (and i'm one of them, still sticking on 1.2.0), and that a lot of people are complaining but it doesn't really immediately imply it's bad and only bad.

Also i read some terrible and hilarious comment about this PR being made only due to the author's ego, while people should know that lmms is one of the most cautios and slow project to merge a PR, and that it wouldn't have been merged if there weren't good reasons behind them. As i said, it's used in other daws as well, and it's more intuitive as it doesn't require to know which keyboard key you need to use with (i personally needed to search online to get how to set the start loop).

This is just to balance things, and i personally think a compromise it's needed as well. For example it could be kept as the new one, while leaving the ability to set the starting point holding shift. This would half the problems shown.

@RiedleroD
Copy link
Contributor

RiedleroD commented Apr 16, 2022

TL;DR: Let's maybe open a discussion regarding this? Github discussions exist for situations like these. Would be best if someone who uses LMMS a lot could open the discussion with a few Pros & Cons of several variants.

I personally like the idea of pressing shift to set the starting point and setting the ending point otherwise. It's very quick and imo also intuitive.

@RoxasKH
Copy link
Contributor

RoxasKH commented Apr 16, 2022

Tbh i can't see how someone that start sentences with TLDR would be open to discuss.

Also i think this issue was already opened a few times, duplicates just get closed, so that discussion is kept only in one place.

@JohannesLorenz
Copy link
Contributor

Duplicate to #5505 . Let's close this?

@Spekular
Copy link
Member

Duplicate to #5505 . Let's close this?

Indeed.

@Spekular Spekular added duplicate and removed bug labels Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants