Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

feat(ui): add zero amount payment request message #3385

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

bolatovumar
Copy link
Contributor

address #1510

Description:

Add a message for why we do not allow zero amount payment request.

Motivation and Context:

Some users are confused when they try to make a payment to a zero amount invoice produced by a service like tippin.me and see an error message saying it's an invalid payment request. This PR adds a more specific message for zero amount payment requests.

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Screen Shot 2020-03-09 at 9 26 30 PM

Types of changes:

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 22.778% when pulling ac9c736 on bolatovumar:add-zero-amount-request-message into 2cf874d on LN-Zap:master.

renderer/components/Form/messages.js Outdated Show resolved Hide resolved
@bolatovumar bolatovumar force-pushed the add-zero-amount-request-message branch from ac9c736 to 88e3fe7 Compare March 12, 2020 02:36
Copy link
Member

@mrfelton mrfelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 88e3fe7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants