Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are broken by #19 #20

Closed
dr-orlovsky opened this issue Jan 18, 2023 · 0 comments · Fixed by #22
Closed

Tests are broken by #19 #20

dr-orlovsky opened this issue Jan 18, 2023 · 0 comments · Fixed by #22
Assignees
@crisdut
Labels
ci Contininous integration-relased issue
Milestone
v0.9.0

Comments

@dr-orlovsky
Copy link
Contributor

#19 had broken CI tests: either this is ok (since the tests were wrong) or the change is not valid.

https://github.com/LNP-WG/lnp-core/actions/runs/3938781953/jobs/6737872327#step:4:236
@dr-orlovsky dr-orlovsky added the ci Contininous integration-relased issue label Jan 18, 2023
@dr-orlovsky dr-orlovsky modified the milestones: v0.9.x, v0.9.0 Jan 18, 2023
@crisdut crisdut mentioned this issue Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crisdut crisdut

Labels
ci Contininous integration-relased issue
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Revert "fix as_remote conditions" crisdut/lnp-core
2 participants
@dr-orlovsky @crisdut