Better export to epub #1144

CD-Z · 2024-07-14T18:55:59Z

I finally found the time to work a bit on the library and implemented it in LNReader with a few changes for better compatibility.

changed lineheight and textsize to be rem based instead of px
changed epub text to be wrapped in div with id chapter instead of a chapter element, since the epub standard doesn't accept custom elements.
added to id chapter to the readerscreen chapter element.

This PR closes:

Some epub exports do not have TOC titles #861
Problem with specific path choosing of epub export #797
Export EPUB: <br> missing on every exported EPUB #777
Cant create epub file from downloaded chapter #696
[Little Flaw]Chapters inside the EPUB are not numbered properly #745
- works as expected
- shouldn't be viewed in the first place
- prevents filename duplications
CustomJS into exported EPUB applies to epub code making the whole JS script not apply #740
- not app/library related

nyagami · 2024-07-15T04:44:19Z

Why should we export reader ui to epub?

nyagami · 2024-07-15T04:53:46Z

package.json

+    "@cd-z/epub-constructor": "^3.0.1",
+    "@cd-z/react-native-epub-creator": "^3.0.0",


Are they duplicated?

I fucked up the dependency so i had to create another version and installed it manually to make sure it works, however it can be removed again since it lt's not neccessary.

nyagami · 2024-07-15T04:54:16Z

package.json

@@ -51,6 +53,7 @@
    "react-native-device-info": "^8.4.7",
    "react-native-drawer-layout": "^3.2.2",
    "react-native-error-boundary": "^1.1.16",
+    "react-native-file-access": "^3.1.0",


Any usage in app?

It belongs to my package as dependency, however if you don't install it manually, for some reason it says the package is not linked and can't be used. Which means the export feature is broken.

nyagami · 2024-07-15T04:56:32Z

scripts/convertCssToJs.cjs

+const jsFilePath = path.resolve(
+  __dirname + '/../android/app/src/main/assets/css/',
+  'index.js',
+);


If this file is created in building time only, it should be ignore from git.

nyagami · 2024-07-15T04:57:59Z

src/screens/novel/components/ExportToEpub/ChooseEpubLocationModal.tsx

@@ -1,6 +1,6 @@
 import React, { useState } from 'react';
 import { StyleSheet, View } from 'react-native';
-import { Modal, TextInput, Text } from 'react-native-paper';
+import { Modal, TextInput, Text } from 'react-native-paper'; //@ts-ignore


Suggested change

import { Modal, TextInput, Text } from 'react-native-paper'; //@ts-ignore

import { Modal, TextInput, Text } from 'react-native-paper';

nyagami · 2024-07-15T04:59:40Z

src/screens/novel/components/ExportToEpub/ExportEpubModal.tsx

+//@ts-ignore
+import css from '../../../../../android/app/src/main/assets/css/index';


for static files, you should import by using require to avoiding TS warning

CD-Z · 2024-07-15T05:04:18Z

Why should we export reader ui to epub?

Where do I export the reader ui?

nyagami · 2024-07-15T05:29:00Z

Why should we export reader ui to epub?

Where do I export the reader ui?

` + (css as string).replace(/chapter/g, '#chapter')

nyagami · 2024-07-15T05:32:01Z

Btw, you could use implemented FileManager.pickerFolder to pick a folder with resolved path.

…tability

Palloxin · 2024-07-27T16:52:53Z

Feature request:
Make chapter file numbering start from chapter 1

The majority of webnovels dont have a chapter before chapter 1.

CD-Z · 2024-07-27T17:36:01Z

Feature request: Make chapter file numbering start from chapter 1

Not planed, since only a minority of users will open the epub

Palloxin · 2024-07-27T20:42:28Z

F-r
Add warning in case the downloaded chapters have hole in between.
chapter 1-8 — downloaded
chapter 9-16 — NOT downloaded
chapter 17-100 — downloaded

It would be nice to know. Not necessary tho.
Hole: like in the example above, means undownloaded stuff between two groups of downloaded chapters.

Palloxin · 2024-07-27T22:15:08Z

Performance issue:
Export speed slower in beta(tested on latest), both 2100+ chapters

beta(2:25):

YouCut_20240728_001100235.mp4

Stable(1:10):

YouCut_20240728_000134690.mp4

Detail: i tested on a beta build that doesnt have the changes of this pr..Commit 7cf8692. It's as fast as stable. I assume this pr modifications are the cause.

Palloxin · 2024-09-07T22:02:13Z

Bug

Export failed due to missing images in a chapter. The chapter is downloaded but somehow the images werent, maybe an app bug or the plugin failed to pick them.

-Novelfull 1.0.0, Cultivation chat group, chapter 841

Solution: override or/and make a window appear that says that these chapter failed for some reason

Palloxin · 2024-09-27T00:46:10Z

Export error:

It comes from an imported EPUB entry.
922k.txt
note: RENAME the extension from .txt to .epub (github doesnt accept epub files)
Import the epub, then try to export it.

Palloxin · 2024-10-06T09:06:39Z

Flaw
Directory error after 2 min of exporting:

The problem is that I used a path that was picked in the past, and somehow it disappeared, so it gave the error.
Solution:
-Check the directory avaiability first, to make the error pop up immediately and not waste 2 minutes.

Palloxin · 2024-10-11T09:01:01Z

Suggestion:
Way to inject directly JS or CSS, ignoring the code in customJS and CSS of the app.
It's a little cumbersome to go there, paste the code and then come back to the entry to export.

It's more comfortable.

CD-Z · 2024-10-11T17:39:12Z

Suggestion: Way to inject directly JS or CSS, ignoring the code in customJS and CSS of the app. It's a little cumbersome to go there, paste the code and then come back to the entry to export.

It's more comfortable.

Why would you want that? What exactly is the use case to have js/css specific only for the epub. Especially when most epub readers don't support it.

Palloxin · 2024-10-11T17:49:21Z

Why would you want that? What exactly is the use case to have js/css specific only for the epub. Especially when most epub readers don't support it.

Just more comfortable. Since js can already be included, allow to directly do it from this place, it's just a shortcut:

Also, IF you have the intention of implementing the Perma-edit feature above, the "especially when most epub readers don't support it" wouldnt matter anymore.

CD-Z · 2024-10-11T18:18:37Z

Well it won't come with this PR, for now I need to find the time to finish this one.

A perma edit would be the best solution to it, however this would also need a lot of work.

nyagami reviewed Jul 15, 2024

View reviewed changes

CD-Z added 11 commits July 27, 2024 15:24

updated epubIconButton for consistend appbar

32c3358

updated exportEpubLocationModal for more consistent style

b329ef7

add app css to epub

d9d4f86

reorganized export to epub filestructure

ba1ceea

switched from px lineheight and textsize to rem for better epub compa…

6b56636

…tability

removed console.logs

6fd7b11

installed @CD-Z npm packages

8543580

replace chapter with #chapter in epub css

4baaaf8

optimizied readerValueChange for epub

532a087

fixed lint issue

88d9607

fixed lint issues again

8c2f8e6

CD-Z force-pushed the feature/export_to_epub_version_bump branch from 28aea06 to 8c2f8e6 Compare July 27, 2024 13:28

CD-Z added 2 commits July 27, 2024 16:00

removed dep package

dd4cb3f

changed to Filemanager.pickfolder

0c245df

This comment was marked as outdated.

Sign in to view

CD-Z added 3 commits July 27, 2024 19:21

forced ascending

2f36985

disable manual change of folder path

48f1779

Added settings warning

d563c8a

lint

53c4f81

This comment was marked as resolved.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better export to epub #1144

Better export to epub #1144

CD-Z commented Jul 14, 2024

nyagami commented Jul 15, 2024

nyagami Jul 15, 2024

CD-Z Jul 15, 2024

nyagami Jul 15, 2024

CD-Z Jul 15, 2024

nyagami Jul 15, 2024

nyagami Jul 15, 2024

nyagami Jul 15, 2024

CD-Z commented Jul 15, 2024

nyagami commented Jul 15, 2024

nyagami commented Jul 15, 2024

This comment was marked as outdated.

Palloxin commented Jul 27, 2024

CD-Z commented Jul 27, 2024

Palloxin commented Jul 27, 2024 •

edited

Loading

Palloxin commented Jul 27, 2024 •

edited

Loading

Palloxin commented Sep 7, 2024 •

edited

Loading

Palloxin commented Sep 27, 2024 •

edited

Loading

Palloxin commented Oct 6, 2024

This comment was marked as resolved.

Palloxin commented Oct 11, 2024

CD-Z commented Oct 11, 2024

Palloxin commented Oct 11, 2024 •

edited

Loading

CD-Z commented Oct 11, 2024

		"@cd-z/epub-constructor": "^3.0.1",
		"@cd-z/react-native-epub-creator": "^3.0.0",

	import { Modal, TextInput, Text } from 'react-native-paper'; //@ts-ignore
	import { Modal, TextInput, Text } from 'react-native-paper';

		//@ts-ignore
		import css from '../../../../../android/app/src/main/assets/css/index';

Better export to epub #1144

Are you sure you want to change the base?

Better export to epub #1144

Conversation

CD-Z commented Jul 14, 2024

nyagami commented Jul 15, 2024

nyagami Jul 15, 2024

Choose a reason for hiding this comment

CD-Z Jul 15, 2024

Choose a reason for hiding this comment

nyagami Jul 15, 2024

Choose a reason for hiding this comment

CD-Z Jul 15, 2024

Choose a reason for hiding this comment

nyagami Jul 15, 2024

Choose a reason for hiding this comment

nyagami Jul 15, 2024

Choose a reason for hiding this comment

nyagami Jul 15, 2024

Choose a reason for hiding this comment

CD-Z commented Jul 15, 2024

nyagami commented Jul 15, 2024

nyagami commented Jul 15, 2024

This comment was marked as outdated.

Palloxin commented Jul 27, 2024

CD-Z commented Jul 27, 2024

Palloxin commented Jul 27, 2024 • edited Loading

Palloxin commented Jul 27, 2024 • edited Loading

Palloxin commented Sep 7, 2024 • edited Loading

Palloxin commented Sep 27, 2024 • edited Loading

Palloxin commented Oct 6, 2024

This comment was marked as resolved.

Palloxin commented Oct 11, 2024

CD-Z commented Oct 11, 2024

Palloxin commented Oct 11, 2024 • edited Loading

CD-Z commented Oct 11, 2024

Palloxin commented Jul 27, 2024 •

edited

Loading

Palloxin commented Jul 27, 2024 •

edited

Loading

Palloxin commented Sep 7, 2024 •

edited

Loading

Palloxin commented Sep 27, 2024 •

edited

Loading

Palloxin commented Oct 11, 2024 •

edited

Loading