Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error messages when Rosetta is not installed #51

Open
filiptibell opened this issue Jul 23, 2023 · 2 comments
Open

Improved error messages when Rosetta is not installed #51

filiptibell opened this issue Jul 23, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@filiptibell
Copy link
Contributor

When running an executable built for x86 on an M1/M2 mac you will get this confusing error message if Rosetta is not installed:
Bad CPU type in executable
Since aftman will always pull x86 executables if a native one is not found for these machines (https://github.com/LPGhatguy/aftman/blob/main/src/tool_source/mod.rs#L36) it might be good for aftman to also be aware of rosetta and point users in the right direction if they don't have it installed.

@LPGhatguy LPGhatguy added the enhancement New feature or request label May 2, 2024
@LPGhatguy
Copy link
Owner

I didn't realize that Rosetta was something that users had to install!

What do you think the best way to detect this failure mode is? I don't want Aftman to emit spurious warnings if we have any false-negatives trying to detect a Rosetta install. Should we bundle an x86-64 binary, try to run it, and see if it works?

@jackTabsCode
Copy link

Unless something has changed, I'm pretty sure that macOS "installs" Rosetta the moment the first x86 application is ran on the machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants