Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing iterators via iter module #24

Closed
toyboot4e opened this issue Apr 16, 2021 · 4 comments
Closed

Exposing iterators via iter module #24

toyboot4e opened this issue Apr 16, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@toyboot4e
Copy link
Contributor

Current documentation:

th-1

Suggestion:

th-2

Code:

pub mod iters {
    //! Iterator types

    pub use crate::drain::Drain;
    pub use crate::drain_filter::DrainFilter;
    pub use crate::into_iter::IntoIter;
    pub use crate::iter::Iter;
    pub use crate::iter_mut::IterMut;
    pub use crate::values::ValuesIter;
    pub use crate::values_mut::ValuesIterMut;
}

Feel free to skip this idea. Thank you :)

@LPGhatguy LPGhatguy added the enhancement New feature or request label Apr 16, 2021
@LPGhatguy
Copy link
Owner

This would be a good organizational change. Should we call this module iters or iter?

@toyboot4e
Copy link
Contributor Author

Ah, I changed my mind: std hides iterators in collection_name module (c.f. std::collections). So I like arena module for hiding iterators, but please choose what you like :)

@LPGhatguy
Copy link
Owner

I feel meh on arena, since this whole crate is just about this one arena type, heh. I think my vote is iter!

@toyboot4e
Copy link
Contributor Author

That makes sense to me! Now I like iter module :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants