Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use lsst.obs.lsst.imsim.ImsimMapper from obs_lsst package #177

Closed
jchiang87 opened this issue Oct 9, 2018 · 9 comments
Closed

use lsst.obs.lsst.imsim.ImsimMapper from obs_lsst package #177

jchiang87 opened this issue Oct 9, 2018 · 9 comments
Assignees

Comments

@jchiang87
Copy link
Collaborator

Once obs_lsstCam is renamed to obs_lsst and integrated into lsst_distrib, we need to update the code in python/desc/imsim/camera_info.py to use lsst.obs.lsst.imsim.ImsimMapper so that the imSim readout parameters (i.e., crosstalk, read noise, gains) are used.

@jchiang87 jchiang87 added the DC2 label Oct 9, 2018
@jchiang87 jchiang87 self-assigned this Oct 9, 2018
@cwwalter
Copy link
Member

cwwalter commented Nov 1, 2018

@heather999 and @danielsf Can you summarize what the status of the camera package transition is and when we need to make this change that Jim tagged?

@danielsf
Copy link
Contributor

danielsf commented Nov 1, 2018

I am not sure that any progress has been made on incorporating obs_lsst into lsst_distrib.

The relevant DM ticket is

https://jira.lsstcorp.org/browse/DM-16374?jql=text%20~%20%22obs_lsstCam%20RFC%22

@heather999
Copy link

The underlying package which is still referred to as "obs_lsstCam" in GitHub, is already renamed to "obs_lsst". So effectively, you have to do a "setup obs_lsst" to setup the package these days. DM has started to make the transition, by turning on some of their protections on this repo: https://lsstc.slack.com/archives/CBE964PR8/p1541014023020800
In our conversations with Leanne, the plan is that obs_lsst will be part of the upcoming v17 DMstack release and that is due to come out this month. So if that all holds up, this transition should be "soon".

@cwwalter
Copy link
Member

cwwalter commented Nov 2, 2018

Thanks both. Do we not make the change Jim refers to above (using lsst.obs.lsst.imsim.ImsimMapper) until that happens?

@heather999
Copy link

That I cannot answer.. If we're gearing up for Run2.1i, then I would guess you'd want to make that transition to lsst.obs.lsst.imsim.ImsimMapper sooner rather than later.

@cwwalter
Copy link
Member

cwwalter commented Nov 3, 2018

Is using lsst.obs.lsst.imsim.ImsimMapper something we can only do after the obs_lsst transition? Or does it also work with obs_lsstCam?

@heather999
Copy link

We don't have to wait for the transition to obs_lsst - that name change to lsst.obs.lsst.imsim.ImsimMapper has been available in obs_lsstCam both in master and along our dc2/run1.2-v2 branch and in the w.2018.39-run1.2 tag). This is compatible with DMstack w_2018_39. The question might be, what version of obs_lsstCam/DMstack weekly are you guys planning to use for Run2.1i?

@cwwalter
Copy link
Member

This issue used for both transitioning to new package and using the new mapper.

@jchiang87
Copy link
Collaborator Author

closed by #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants