-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use lsst.obs.lsst.imsim.ImsimMapper from obs_lsst package #177
Comments
@heather999 and @danielsf Can you summarize what the status of the camera package transition is and when we need to make this change that Jim tagged? |
I am not sure that any progress has been made on incorporating The relevant DM ticket is https://jira.lsstcorp.org/browse/DM-16374?jql=text%20~%20%22obs_lsstCam%20RFC%22 |
The underlying package which is still referred to as "obs_lsstCam" in GitHub, is already renamed to "obs_lsst". So effectively, you have to do a "setup obs_lsst" to setup the package these days. DM has started to make the transition, by turning on some of their protections on this repo: https://lsstc.slack.com/archives/CBE964PR8/p1541014023020800 |
Thanks both. Do we not make the change Jim refers to above (using lsst.obs.lsst.imsim.ImsimMapper) until that happens? |
That I cannot answer.. If we're gearing up for Run2.1i, then I would guess you'd want to make that transition to lsst.obs.lsst.imsim.ImsimMapper sooner rather than later. |
Is using lsst.obs.lsst.imsim.ImsimMapper something we can only do after the obs_lsst transition? Or does it also work with obs_lsstCam? |
We don't have to wait for the transition to obs_lsst - that name change to lsst.obs.lsst.imsim.ImsimMapper has been available in obs_lsstCam both in master and along our dc2/run1.2-v2 branch and in the w.2018.39-run1.2 tag). This is compatible with DMstack w_2018_39. The question might be, what version of obs_lsstCam/DMstack weekly are you guys planning to use for Run2.1i? |
This issue used for both transitioning to new package and using the new mapper. |
closed by #190 |
Once
obs_lsstCam
is renamed toobs_lsst
and integrated intolsst_distrib
, we need to update the code inpython/desc/imsim/camera_info.py
to uselsst.obs.lsst.imsim.ImsimMapper
so that the imSim readout parameters (i.e., crosstalk, read noise, gains) are used.The text was updated successfully, but these errors were encountered: