Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parameterized PSFs vary over the focal plane #70

Closed
cwwalter opened this issue Oct 4, 2017 · 5 comments
Closed

Make parameterized PSFs vary over the focal plane #70

cwwalter opened this issue Oct 4, 2017 · 5 comments

Comments

@cwwalter
Copy link
Member

cwwalter commented Oct 4, 2017

Currently (with a parameterized PSF) the PSF does not vary over the focal plane.

With the addition of #37 (passing the focal plane position to GalSim) this could be modified and a parameterized function could be used in GalSim.

On the other hand with a ray-traced atmosphere and an extra phase screen representing the perturbed optics (#9) I believe this would be naturally emergent. So hopefully we get this in DC2 by implementing the other two options.

@cwwalter cwwalter added the DC2 label Oct 4, 2017
@jchiang87
Copy link
Collaborator

jchiang87 commented Oct 4, 2017

With the addition of #37 (passing the focal plane position to GalSim) this could be modified and a parameterized function could be used in GalSim.

Even with an emergent implementation, it would be nice to have this option in case we want to test or develop interpolation schemes using these simulations.

@cwwalter
Copy link
Member Author

I think between #9 and #101 we now have a PSF which varies over the focal plane.

But we still might want to have this as a an option with parameterized PSFs (coupled with #37) so we could study PSF interpolation schemes as mentioned by Jim above. So, am leaving this issue live but removing the DC2 label since I think we have implemented the feature there.

@cwwalter cwwalter removed the DC2 label May 22, 2018
@cwwalter cwwalter changed the title Make the PSF vary over the focal plane Make parameterized PSFs vary over the focal plane Jul 5, 2018
@cwwalter
Copy link
Member Author

Hi All,

This is a very old issue and the way we do PSF and the work the PSF group is doing is quite a bit different now.

Is this sort of thing something that the PSF group would still be interested in?

@rmjarvis
Copy link
Contributor

There are lots of ways in the config structure to have parameterized PSfs vary over the focal plane. I don't think we need something specific to imSim about this.

@cwwalter
Copy link
Member Author

OK closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants